Skip to content

fix(examples): the carousel sets leading in points, not multiples #500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DemchaAV merged 1 commit into from
Aug 4, 2026
Merged

fix(examples): the carousel sets leading in points, not multiples #500

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions examples/src/main/java/com/demcha/examples/flagships/LinkedInCarouselExample.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,10 @@ private static void cover(SectionBuilder slide) {
slide.addParagraph(p -> p
.text("One composition.\nTwo formats.")
.textStyle(headline(132))
.lineSpacing(1.03)
// lineSpacing is EXTRA space in points, not a multiplier: the layout
// adds it between wrapped lines on top of the font's own line height.
// Display type needs proportionally less of it than body copy.
.lineSpacing(8 * SCALE)
.margin(DocumentInsets.zero()));
slide.addShape(shape -> shape.size(160 * SCALE, 7 * SCALE).fillColor(VIOLET)
.margin(DocumentInsets.symmetric(14, 0)));
Expand All @@ -240,7 +243,7 @@ private static void cover(SectionBuilder slide) {
+ "backend — so PDF and PowerPoint are the same geometry, "
+ "not two hand-kept designs.")
.textStyle(body(40, ON_DARK_MUTED))
.lineSpacing(1.45)
.lineSpacing(5 * SCALE)
.margin(DocumentInsets.zero()));
slide.addRow("Formats", row -> {
row.spacing(14 * SCALE).evenWeights();
Expand All @@ -258,7 +261,7 @@ private static void backendSlide(SectionBuilder slide) {
slide.addParagraph(p -> p
.text("PowerPoint is a\nfirst-class backend.")
.textStyle(headline(82))
.lineSpacing(1.06)
.lineSpacing(6 * SCALE)
.margin(DocumentInsets.zero()));
point(slide, "Fixed layout, not export", MINT,
"PptxFixedLayoutBackend implements the same FixedLayoutRenderer "
Expand Down Expand Up @@ -318,7 +321,7 @@ private static void guaranteesSlide(SectionBuilder slide) {
slide.addParagraph(p -> p
.text("Guarantees you\ncan run.")
.textStyle(headline(82))
.lineSpacing(1.06)
.lineSpacing(6 * SCALE)
.margin(DocumentInsets.zero()));
point(slide, "Deterministic layout snapshots", VIOLET_LIGHT,
"Every flagship document has its geometry recorded as JSON. A layout "
Expand Down Expand Up @@ -420,7 +423,7 @@ private static void point(SectionBuilder slide, String title, DocumentColor acce
card.addParagraph(p -> p
.text(body)
.textStyle(body(28, ON_DARK_MUTED))
.lineSpacing(1.4)
.lineSpacing(4 * SCALE)
.margin(DocumentInsets.zero()));
});
}
Expand Down Expand Up @@ -471,7 +474,7 @@ private static void ratio(RowBuilder row, String value, String label, DocumentCo
card.addParagraph(p -> p
.text(label)
.textStyle(body(24, ON_DARK_MUTED))
.lineSpacing(1.25)
.lineSpacing(3 * SCALE)
.margin(DocumentInsets.zero()));
});
}
Expand Down Expand Up @@ -506,7 +509,7 @@ private static ChartStyle latencyStyle() {
private static ParagraphBuilder footnote(ParagraphBuilder p, String text) {
return p.text(text)
.textStyle(body(22, DocumentColor.rgb(130, 139, 170)))
.lineSpacing(1.4)
.lineSpacing(3 * SCALE)
.margin(DocumentInsets.top(6 * SCALE));
}

Expand Down
Loading