chore(examples): the carousel's value labels read in amber - #504
Merged
Conversation
The numbers sat in the card's own light-on-dark body colour, one step from the violet bars they label and indistinguishable from the axis chrome around them. Amber separates them from both and lands on the accent the slide is already built from — the same colour as its eyebrow and its Jasper ratio tile, so the measurements read as one thread rather than three unrelated highlights. The halo stays the card fill: it is there to cut the gridline out from behind a label, and a coloured chip would have turned an invisible fix into a badge.
DemchaAV
force-pushed
the
feat/carousel-amber-value-labels
branch
from
August 4, 2026 11:56
0013a83 to
e2d302f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
On the carousel's benchmark slide the value labels used the deck's body colour — a
light neutral one step from the violet bars they sit on and identical to the axis
chrome around them. The numbers are the point of the slide and read as the least
distinct thing on it.
Amber is already the slide's accent: its eyebrow (MEASURED, NOT CLAIMED) and its
third ratio tile (2.7x lighter than Jasper) are both in it. Moving the labels there
separates them from the bars and ties the measurements into one thread instead of
adding a fourth colour.
What
latencyStyle()setsvalueLabelTextStyleto amber. Contrast against the card fillis 7.6:1.
The halo stays the card colour. It exists to cut the gridline out from behind a label
— a coloured chip would turn an invisible fix into a badge, which is a different
design decision than the one asked for here.
Tests
./mvnw -B -ntp clean verify→BUILD SUCCESS, withCommittedAssetDriftTestgreen:the carousel is listed in that guard's
UNPUBLISHED_PREVIEWS, so no file underassets/readme/moves and none needs re-committing.Rendered and inspected page 4 of
examples/target/generated-pdfs/flagships/linkedin-carousel.pdf.