fix(search): honor the label filter in BM25 keyword search (#2148) - #2159
Open
htarnacki wants to merge 1 commit into
Open
fix(search): honor the label filter in BM25 keyword search (#2148)#2159htarnacki wants to merge 1 commit into
htarnacki wants to merge 1 commit into
Conversation
|
Thanks for opening this — it has been seen, and it is queued. This note is automated, but it is not a brush-off: it exists so you know where your PR stands instead of having to guess from silence. Current review status: working through a backlog. What that means for this PR, concretely:
Things that will genuinely speed it up whenever review does happen:
If this fixes a bug, a reproduction we can run is worth more than a description of the symptom. Thanks for contributing, and sorry in advance for the wait. |
htarnacki
force-pushed
the
fix/bm25-label-filter
branch
from
September 10, 2026 09:21
8488e3a to
8d353a5
Compare
`search_graph` accepted a `label` argument, but the BM25 keyword branch ignored it and returned nodes of every label. Bind the label into both BM25 queries so keyword results respect the same filter as the other search paths. Signed-off-by: Hubert Tarnacki <hubert.tarnacki@gmail.com>
htarnacki
force-pushed
the
fix/bm25-label-filter
branch
from
September 10, 2026 11:16
8d353a5 to
7e111f8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #2148.
search_graphhonourslabelon the name-pattern and semantic branches but not on the BM25 keyword branch, soquery+labelreturned nodes of every label. The label is now bound into both BM25 statements (FTS lookup and the fallback), matching the other search paths. One commit, MCP-level test intest_mcp.c(Routevs same-namedFunction).Checklist
git commit -s) — required, CI rejectsunsigned commits (DCO, see CONTRIBUTING.md)
make -f Makefile.cbm test) — all suites green except 10test_cli.cinstall/uninstall cases that fail identically on a cleanmainin my environment (activation transaction I/O failed: target-entry-snapshot, environment-specific).make -f Makefile.cbm lint-ci) —clang-format-20andcheck-dco.shclean;clang-tidy/cppcheckare not installed locally, relying on CI for those two.