fix(cli): accept JSON array literals for array-typed arguments (#2150) - #2160
Open
htarnacki wants to merge 1 commit into
Open
fix(cli): accept JSON array literals for array-typed arguments (#2150)#2160htarnacki wants to merge 1 commit into
htarnacki wants to merge 1 commit into
Conversation
|
Thanks for opening this — it has been seen, and it is queued. This note is automated, but it is not a brush-off: it exists so you know where your PR stands instead of having to guess from silence. Current review status: working through a backlog. What that means for this PR, concretely:
Things that will genuinely speed it up whenever review does happen:
If this fixes a bug, a reproduction we can run is worth more than a description of the symptom. Thanks for contributing, and sorry in advance for the wait. |
`codebase-memory-mcp cli <tool> --flag value` builds the tool's JSON arguments from typed flags. Array-typed parameters such as `semantic_query` were only accepted as repeated flags (`--semantic-query a --semantic-query b`); passing the JSON spelling shown in the MCP schema (`--semantic-query '["a","b"]'`) was stored as a single opaque string element, so the search ran against the literal text `["a","b"]` instead of two keywords. Parse a value that is a JSON array of strings into individual elements. Any other value keeps the existing behaviour, so repeated flags and plain strings are unaffected. Signed-off-by: Hubert Tarnacki <hubert.tarnacki@gmail.com>
htarnacki
force-pushed
the
fix/cli-json-array-args
branch
from
September 10, 2026 10:12
f7b56b9 to
b3af448
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #2150.
codebase-memory-mcp cli <tool> --flag valuestored a JSON array literal passed to an array-typed flag (--semantic-query '["a","b"]') as a single string element, so the search ran against the literal text.cli_add_typednow expands a value that starts with[and parses as a non-empty JSON array of strings into individual elements; every other value (repeated flags, plain strings, non-array JSON) keeps the current behaviour. One commit, unit test intest_cli.c.Checklist
git commit -s) — required, CI rejectsunsigned commits (DCO, see CONTRIBUTING.md)
make -f Makefile.cbm test) — all suites green except 10test_cli.cinstall/uninstall cases that fail identically on a cleanmainin my environment (activation transaction I/O failed: target-entry-snapshot, environment-specific).make -f Makefile.cbm lint-ci) —clang-format-20andcheck-dco.shclean;clang-tidy/cppcheckare not installed locally, relying on CI for those two.