fix(discover): retain external source directories in fast mode (#2151) - #2161
Open
htarnacki wants to merge 1 commit into
Open
fix(discover): retain external source directories in fast mode (#2151)#2161htarnacki wants to merge 1 commit into
htarnacki wants to merge 1 commit into
Conversation
|
Thanks for opening this — it has been seen, and it is queued. This note is automated, but it is not a brush-off: it exists so you know where your PR stands instead of having to guess from silence. Current review status: working through a backlog. What that means for this PR, concretely:
Things that will genuinely speed it up whenever review does happen:
If this fixes a bug, a reproduction we can run is worth more than a description of the symptom. Thanks for contributing, and sorry in advance for the wait. |
`external` was listed in FAST_SKIP_DIRS, so fast and moderate discovery silently dropped every directory named `external`. In many codebases that name holds first-party code (external-facing APIs, adapters, integration layers) rather than vendored third-party sources, and the dedicated `vendor` / `third_party` / `3rdparty` entries already cover the vendored case. Remove `external` from the fast skip list so those sources are indexed in every mode. The shortened list is regrouped with category comments in the same style as ALWAYS_SKIP_DIRS; element order is unchanged. Signed-off-by: Hubert Tarnacki <hubert.tarnacki@gmail.com>
htarnacki
force-pushed
the
fix/discover-external-fast-mode
branch
from
September 10, 2026 10:12
c8e244d to
6790e1a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #2151.
externalwas listed inFAST_SKIP_DIRS, so fast and moderate discovery silently dropped every directory with that name — in many codebases first-party code (external-facing APIs, adapters, integration layers). The vendored case remains covered byvendor,vendored,third_party,thirdparty,3rdparty. This removes the singleexternalentry and addsno_skip_fast_externaltotest_discover.c.Diff note:
clang-format-20reflows the shortened initializer to one item per line, so the list is regrouped with category comments in the same style asALWAYS_SKIP_DIRS; order and the other entries are unchanged.Related: #1406, #1184 (same silent-exclusion family; not addressed here).
Checklist
git commit -s) — required, CI rejectsunsigned commits (DCO, see CONTRIBUTING.md)
make -f Makefile.cbm test) — all suites green except 10test_cli.cinstall/uninstall cases that fail identically on a cleanmainin my environment (activation transaction I/O failed: target-entry-snapshot, environment-specific).make -f Makefile.cbm lint-ci) —clang-format-20andcheck-dco.shclean;clang-tidy/cppcheckare not installed locally, relying on CI for those two.