Repository navigation
Conversation
Signed-off-by: 霜冻公爵 <swqsldz@163.com>
|
Thanks for opening this — it has been seen, and it is queued. This note is automated, but it is not a brush-off: it exists so you know where your PR stands instead of having to guess from silence. Current review status: working through a backlog. What that means for this PR, concretely:
Things that will genuinely speed it up whenever review does happen:
If this fixes a bug, a reproduction we can run is worth more than a description of the symptom. Thanks for contributing, and sorry in advance for the wait. |
…Data#2657 opened after the sync Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: SanHsien <34234698+SanHsien@users.noreply.github.com>
|
Thanks for the detailed Windows lock-preparation report and for clearly marking the validation limits. I have read the draft and its distinction from #2639; the focused regression result is still listed as pending. Please update the description with that result when available. This remains pending review. |
What does this PR do?
Fixes #2656.
A CLI mutation can repeatedly time out before it finishes Windows native lock preparation: the old 100 ms attempt expires while ownership/path/ACL checks are still progressing, so the outer retry discards partial work and starts over.
Use a 5000 ms Windows-only per-attempt budget. Other platforms retain 100 ms. Saturating deadline arithmetic, nonblocking calls, the native security checks, lock ordering, and cleanup semantics are preserved.
Change and regression coverage
This changes five C/header files. It changes no MCP arguments, configuration defaults, dependencies, or build rules.
The large-database watch-registration issue #2655 is separate and is already addressed by the predicate replacement in #2639; that fix is intentionally absent from this branch.
Verification
scripts/test.sh --suites project_lock BUILD_DIR=build/upstream-lock-testsusing an isolated Clang/MinGW UCRT 22.1.8 toolchain with ASan/UBSan and locally built zlib.
LDFLAGS_TESTaccidentally omitted the upstream mimalloc--wrapoptions (__real_free/__real__msizewere unresolved). These are not regression results. The corrected run supplies zlib throughCPATH/LIBRARY_PATHand retains all upstream link flags. The isolated zlib/sanitizer compile-and-run probe passed.INT_MAXrange diagnostic at unchangedsrc/foundation/limits.c:39; no whole-tree lint pass is claimed.This remains a Draft while the focused regression and complete CI are pending. Fresh-cache CLI follow-up fixtures were rejected before indexing by saved-runtime-settings initialization; those failed fixture attempts are not counted as lock reproductions.
Checklist
Written with Codex assistance on behalf of the account owner.