Repository navigation
Fix build against musl - #2675
attilaolah wants to merge 2 commits into
Conversation
|
Thanks for opening this — it has been seen, and it is queued. This note is automated, but it is not a brush-off: it exists so you know where your PR stands instead of having to guess from silence. Current review status: working through a backlog. What that means for this PR, concretely:
Things that will genuinely speed it up whenever review does happen:
If this fixes a bug, a reproduction we can run is worth more than a description of the symptom. Thanks for contributing, and sorry in advance for the wait. |
Signed-off-by: Attila Oláh <attila@dorn.haus>
Signed-off-by: Attila Oláh <attila@dorn.haus>
|
There seem to be multiple pre-existing linter warnings, none of them seem to be related to this change. |
|
Many of the grammar tests are also failing, not sure yet whether they are caused by my change. Final results: Plus many leaks detected by the sanitizer. |
What does this PR do?
Makes
codebase-memory-mcpbuild againstmusllibc.$LDenv var, instead of hard-codingld.phaseandlogwhennull, since passing those to%swithmusl-gccis UB.Checklist
git commit -s) — required, CI rejectsunsigned commits (DCO, see CONTRIBUTING.md)
make -f Makefile.cbm test -j$(nproc))make -f Makefile.cbm lint-ci)