feat: replace legacy emojis with professional lucide icons#96
Open
KGFCH2 wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses Issue #95 by replacing legacy emoji-based UI accents in the web app with Lucide SVG icons, improving visual consistency and professionalism.
Changes:
- Added
lucide-svelteto the web app dependencies and lockfile. - Replaced emoji icons with Lucide icon components in the landing page and user profile page.
- Updated call-to-action and navigation affordances to use consistent iconography.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
pnpm-lock.yaml |
Adds lucide-svelte resolution entries; also surfaces a deprecated/vulnerability warning for @ungap/structured-clone@1.3.0. |
apps/web/package.json |
Adds lucide-svelte dependency for the web app. |
apps/web/src/routes/+page.svelte |
Replaces emojis with Lucide icons on the landing page (theme toggle, logo, CTAs, features). |
apps/web/src/routes/u/[username]/+page.svelte |
Replaces emojis/arrows with Lucide icons on the user page (error state, link tiles, CTA). |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
1929
to
+1931
| '@ungap/structured-clone@1.3.0': | ||
| resolution: {integrity: sha512-WmoN8qaIAo7WTYWbAZuG8PYEhn5fkz7dZrqTBZ7dtt//lL2Gwms1IcnQ5yHqjDfX8Ft5j4YzDM23f87zBfDe9g==} | ||
| deprecated: Potential CWE-502 - Update to 1.3.1 or higher |
Comment on lines
68
to
+73
| href="https://github.com/Dev-Card/DevCard" | ||
| class="btn btn-primary" | ||
| target="_blank" | ||
| rel="noopener" | ||
| > | ||
| ⭐ Star on GitHub | ||
| <Star size={18} fill="currentColor" /> Star on GitHub |
Comment on lines
+51
to
+59
| {#if theme === 'light'} | ||
| <Moon size={20} /> | ||
| {:else} | ||
| <Sun size={20} /> | ||
| {/if} | ||
| </button> | ||
| <div class="logo">⚡</div> | ||
| <div class="logo"> | ||
| <Zap size={64} strokeWidth={2.5} fill="currentColor" /> | ||
| </div> |
Comment on lines
+57
to
+59
| <div class="logo"> | ||
| <Zap size={64} strokeWidth={2.5} fill="currentColor" /> | ||
| </div> |
Comment on lines
+37
to
+40
| <div class="error-emoji"><Frown size={64} /></div> | ||
| <h1>User Not Found</h1> | ||
| <p>This DevCard doesn't exist or has been removed.</p> | ||
| <a href="/" class="home-link">← Back to DevCard</a> | ||
| <a href="/" class="home-link"><ArrowLeft size={18} style="display: inline; vertical-align: middle; margin-right: 4px;" /> Back to DevCard</a> |
| <h1>User Not Found</h1> | ||
| <p>This DevCard doesn't exist or has been removed.</p> | ||
| <a href="/" class="home-link">← Back to DevCard</a> | ||
| <a href="/" class="home-link"><ArrowLeft size={18} style="display: inline; vertical-align: middle; margin-right: 4px;" /> Back to DevCard</a> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue: Closes #95
Summary: Replace legacy emojis with professional Lucide icons.