fix(ios): replace sleep(5) in applicationWillTerminate with bounded wait - #400
Open
vaibhavppandey wants to merge 1 commit into
Open
vaibhavppandey wants to merge 1 commit into
vaibhavppandey wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
One or more issues must be addressed before approval.
Review effort: Lite
Findings: None
What changed in this PR
Replaces iOS termination’s fixed five-second sleep with a bounded, run-loop-responsive wait for Dart onDestroy completion.
Changes:
- Adds destruction completion callbacks through the service layers.
- Waits up to two seconds while processing the main run loop.
| File | Description |
|---|---|
| ios/flutter_foreground_task/Sources/flutter_foreground_task/SwiftFlutterForegroundTaskPlugin.swift | Updated as part of this pull request. |
| ios/flutter_foreground_task/Sources/flutter_foreground_task/service/ForegroundTask.swift | Updated as part of this pull request. |
| ios/flutter_foreground_task/Sources/flutter_foreground_task/service/BackgroundService.swift | Updated as part of this pull request. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Author
|
@Dev-hwang could you please review this PR? It fixes #399 (iOS apps getting killed with 0x8BADF00D when terminated while the service is running). Tested on device. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #399
Replaces the fixed
sleep(5)inapplicationWillTerminatewith a wait on the actualonDestroyreply, capped at 2s. While waiting, the main run loop keeps running so the reply and any platform-channel calls fromonDestroycan be handled.ForegroundTask.destroy()/BackgroundService.run()take an optionalonDestroyedcallback, fired when DartonDestroyreplies, or immediately when there is nothing to wait for.stopServiceis unchanged.Tested (example app, iOS 18.7.8, profile build, swiped away from the app switcher):
onDestroyran