chore: migrate gulp build devextreme-scss task to nx#33729
Open
GoodDayForSurf wants to merge 46 commits into
Open
chore: migrate gulp build devextreme-scss task to nx#33729GoodDayForSurf wants to merge 46 commits into
GoodDayForSurf wants to merge 46 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces Nx-based infrastructure for building DevExtreme SCSS themes by adding a dedicated scss-build executor in nx-infra-plugin, consolidating data-uri(...) handling into a shared utility, and switching the devextreme package’s build-themes script to call nx build devextreme-scss.
Changes:
- Added shared SCSS
data-uri(...)encoding utilities + Jest coverage. - Added a new
devextreme-nx-infra-plugin:scss-buildexecutor implementation for bundling/compiling/minifying theme CSS. - Updated SCSS assembly to reuse the shared
data-uri(...)utility; updatedbuild-themesscript to invoke Nx.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/nx-infra-plugin/src/utils/scss-data-uri.ts | Adds reusable helpers for encoding assets into data: URIs (SVG UTF-8, others base64) + shared regex. |
| packages/nx-infra-plugin/src/utils/scss-data-uri.spec.ts | Adds Jest tests for the new data-uri encoding helpers. |
| packages/nx-infra-plugin/src/executors/scss-build/scss-build.impl.ts | Introduces Nx executor logic for generating SCSS bundles, compiling via sass-embedded, autoprefixing, minifying, and (in watch mode) copying assets. |
| packages/nx-infra-plugin/src/executors/scss-build/executor.ts | Exports the new executor implementation. |
| packages/nx-infra-plugin/src/executors/scss-assemble/scss-assemble.impl.ts | Replaces local data-uri logic with the shared utility functions/regex. |
| packages/devextreme/package.json | Switches build-themes to pnpm nx build devextreme-scss. |
GoodDayForSurf
force-pushed
the
chore/migrate-devextreme-scss-to-nx
branch
from
c0eec2e to
16a1a21
Compare
…com/DevExpress/DevExtreme into chore/migrate-devextreme-scss-to-nx # Conflicts: # pnpm-lock.yaml
…chore/migrate-devextreme-scss-to-nx # Conflicts: # package.json
| filePathOrExt: string, | ||
| svgEncoding?: string, | ||
| ): string { | ||
| const ext = path.extname(filePathOrExt).replace('.', '').toLowerCase(); |
Comment on lines
+267
to
+274
| const sources = await resolveSourceFiles(projectRoot, options); | ||
| const existingSources = sources.filter((source) => fs.existsSync(source)); | ||
| const minifyProfile: MinifyProfile = options.mode === 'ci' ? 'ci' : 'all'; | ||
|
|
||
| for (const source of existingSources) { | ||
| logger.verbose(`Compiling ${source}`); | ||
| await compileFile(source, cssOutputDir, minifyProfile, deps, projectRoot); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.