Repository navigation
Remove unused pose aliases and NFC adapter exports - #41
Merged
Merged
Conversation
Drop deprecated avatar pose re-exports and test-only animation builders that production never called. Remove sharing's unused NDEF encounter decoder, ingest stream, and related tests; the app reads tags via amiroLinkTextFromNdef and ManagerNfcReader. Co-authored-by: Uday Chauhan <chauhan.s.uday26@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to the dead-code survey on
main(98a67c4). Removes symbols that had zero production references (verified via repo-wide search and green CI test suite).avatar_renderer@Deprecatedpose API aliases (shouldApplyRelaxedArmPose,relaxedArmPoseFrame,applyRelaxedArmPose).buildRelaxedArmPoseAnimation,buildLivingStatueIdleAnimation); runtime already usesbuildSkinnedHumanoidPresentationAnimation/applySkinnedHumanoidProceduralMotion.confidentFashionArmPoseFrame.sharingdecodeEncounterFromNdef,encounterTextFromNdef,ingestNfcReads, andNfcRead/NfcEncounterRead/NfcReadRejected.ndefRecordText,encodeNdefTextPayload,amiroLinkTextFromNdef(used byManagerNfcReader).Docs
TODOS.mdto noteingestNfcReadsremoval.Verification
melos run analyze— no issues (9 packages)melos run test— all tests passed (including app widget tests after thermion native deps)Risk
Low: no app/lib or
nfccall sites referenced the deleted sharing exports; avatar pose changes are internal toavatar_body_pose.dart.