Repository navigation
Remove dead code from dead-code survey (pose, NFC, exports) - #42
Merged
Merged
Conversation
Drop deprecated avatar pose re-exports and test-only animation builders that production never called. Remove sharing's unused NDEF encounter decoder, ingest stream, and related tests; the app reads tags via amiroLinkTextFromNdef and ManagerNfcReader. Co-authored-by: Uday Chauhan <chauhan.s.uday26@gmail.com>
Stop exporting internal asset paths and Filament test seams from the package barrel; tests import src paths directly. Align TODOS with the shipped encounter NFC path and removed NDEF adapter APIs. Co-authored-by: Uday Chauhan <chauhan.s.uday26@gmail.com>
Resolve TODOS.md PR5 section: keep shipped NFC wiring notes and document removal of unused NDEF adapter APIs. Co-authored-by: Uday Chauhan <chauhan.s.uday26@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the high-confidence dead-code items from the survey on
main(98a67c4). One PR for merge-all-at-once.Removed (~350 lines)
avatar_renderershouldApplyRelaxedArmPose,relaxedArmPoseFrame,applyRelaxedArmPosebuildRelaxedArmPoseAnimation,buildLivingStatueIdleAnimationsharingdecodeEncounterFromNdef,encounterTextFromNdef,ingestNfcReads,NfcRead/NfcEncounterRead/NfcReadRejectedndef_encounter_test.dartPublic API tightening
avatar_rendererbarrel now exports only what the app uses:AvatarRenderer,ThermionAvatarRenderer,ThermionViewDetachGateresolveAssetPath,FilamentSurface, orThermionFilamentSurface(internal / test seams)Docs
TODOS.md— removed contradictory PR5/PR6 bullets about unmigrated NFC and legacy-only share links; documents removal ofingestNfcReads/decodeEncounterFromNdef.Intentionally kept (survey noted, not dead)
encodeNdefTextPayloadbuildShareUri/parseShareUriamiro://sharereceive path still liverust/corelib/**/*.dartfilesNo unused-import/unused-element analyzer warnings before or after; no pubspec dependency removals (none were zero-reference at direct-declaration level).
Verification
melos run analyze— 9/9 packages cleanmelos run test— all passed (153 app + package tests)