Return port number or zero otherwise in forward command#457
Open
yotamN wants to merge 1 commit intoDeviceFarmer:masterfrom
Open
Return port number or zero otherwise in forward command#457yotamN wants to merge 1 commit intoDeviceFarmer:masterfrom
yotamN wants to merge 1 commit intoDeviceFarmer:masterfrom
Conversation
Member
|
Your PR does not pass the checks. |
|
It should not break backward compatibility |
Author
|
I will make sure it passes the tests but regarding backward compatibility, I'm not sure how you want me to do it.
|
66fe5c9 to
d483403
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #456