fix: fix memory leak after writing data with false result#542
Open
harlentan wants to merge 2 commits intoDeviceFarmer:masterfrom
Open
fix: fix memory leak after writing data with false result#542harlentan wants to merge 2 commits intoDeviceFarmer:masterfrom
harlentan wants to merge 2 commits intoDeviceFarmer:masterfrom
Conversation
Signed-off-by: haiyan.tan <haiyan.tan@alibaba-inc.com>
…th false result Signed-off-by: haiyan.tan <haiyan.tan@alibaba-inc.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There will be memory leak when sending big apk to Android device, because the
waitForDrainwill never be called.adbkit/src/adb/sync.ts
Line 194 in f458f6a
The
if (this.connection.write(chunk, track))will always be true,adbkit/src/adb/connection.ts
Line 81 in f458f6a
Nodejs AP reference:
https://nodejs.org/api/stream.html#writablewritechunk-encoding-callback