Release Help/Release Notes WebView when leaving the page#5131
Merged
Conversation
Marc-André Moreau (mamoreau-devolutions)
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves resource management for pages hosting WebView2 controls by ensuring that the associated processes are properly released when navigating away from the Help or Release Notes pages. This change prevents unnecessary resource usage and potential memory leaks by disposing of these pages and their WebView2 instances when they are no longer in use.
Resource management improvements for WebView2 pages:
IDisposableinterface and aDisposemethod to bothHelpPageandReleaseNotesPage, which stops the WebView2 control and detaches it from the UI when the page is disposed.ReleaseWebViewPagemethod inMainWindowViewModelto dispose of and release cached instances ofHelpPageandReleaseNotesPagewhen navigating away from them, ensuring their WebView2 process clusters are freed.MainWindowViewModel.NavigateToto callReleaseWebViewPagewhen switching pages, further ensuring proper cleanup of WebView2 resources.