Skip to content

Use config server for OAV config files#1748

Open
jacob720 wants to merge 46 commits intomainfrom
mx_bluesky_1448_use_config_server
Open

Use config server for OAV config files#1748
jacob720 wants to merge 46 commits intomainfrom
mx_bluesky_1448_use_config_server

Conversation

@jacob720
Copy link
Copy Markdown
Contributor

@jacob720 jacob720 commented Dec 1, 2025

Fixes DiamondLightSource/mx-bluesky#1448
Required by DiamondLightSource/mx-bluesky#1521

Instructions to reviewer on how to test:

  1. Check OAV config is read through config server

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@jacob720 jacob720 requested a review from a team as a code owner December 1, 2025 14:51
@jacob720 jacob720 marked this pull request as draft December 1, 2025 14:51
@jacob720 jacob720 force-pushed the mx_bluesky_1448_use_config_server branch from 9da091c to 51d8973 Compare December 1, 2025 16:10
@jacob720 jacob720 force-pushed the mx_bluesky_1448_use_config_server branch from 7330069 to c054435 Compare March 13, 2026 12:07
@jacob720 jacob720 changed the base branch from main to mx_bluesky_1504_migrate_beamline_parameters_to_config_server March 13, 2026 14:06
@jacob720 jacob720 force-pushed the mx_bluesky_1448_use_config_server branch from 2f9a02e to 20d30e1 Compare March 13, 2026 14:15
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.08%. Comparing base (690e423) to head (dcb61d1).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1748      +/-   ##
==========================================
- Coverage   99.11%   99.08%   -0.04%     
==========================================
  Files         318      318              
  Lines       12361    12354       -7     
==========================================
- Hits        12252    12241      -11     
- Misses        109      113       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Base automatically changed from mx_bluesky_1504_migrate_beamline_parameters_to_config_server to main March 13, 2026 16:26
@jacob720 jacob720 marked this pull request as ready for review March 27, 2026 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate OAV configuration to use config server

1 participant