Skip to content

1875 add i10 1 high field magnet devices#1876

Open
Relm-Arrowny wants to merge 22 commits intomainfrom
1875-add-i10-1-high-field-magnet-devices
Open

1875 add i10 1 high field magnet devices#1876
Relm-Arrowny wants to merge 22 commits intomainfrom
1875-add-i10-1-high-field-magnet-devices

Conversation

@Relm-Arrowny
Copy link
Contributor

@Relm-Arrowny Relm-Arrowny commented Jan 28, 2026

Fixes #1945

Instructions to reviewer on how to test:

  1. Do thing x
  2. Confirm thing y happens

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@Relm-Arrowny Relm-Arrowny linked an issue Jan 28, 2026 that may be closed by this pull request
3 tasks
@Relm-Arrowny Relm-Arrowny changed the base branch from main to 1865-add-i10-1-electromagnet-endstation January 28, 2026 15:41
@codecov
Copy link

codecov bot commented Jan 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.06%. Comparing base (178425f) to head (34e35f2).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1876   +/-   ##
=======================================
  Coverage   99.05%   99.06%           
=======================================
  Files         314      315    +1     
  Lines       11779    11870   +91     
=======================================
+ Hits        11668    11759   +91     
  Misses        111      111           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Base automatically changed from 1865-add-i10-1-electromagnet-endstation to main January 29, 2026 15:03
@oliwenmandiamond
Copy link
Contributor

Your dodal.devices.i10 will need to be moved to dodal.devices.beamlines.i10

@Relm-Arrowny Relm-Arrowny linked an issue Feb 26, 2026 that may be closed by this pull request
@Relm-Arrowny Relm-Arrowny marked this pull request as ready for review February 27, 2026 11:57
@Relm-Arrowny Relm-Arrowny requested a review from a team as a code owner February 27, 2026 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add magnetic field controller.

2 participants