Skip to content

Update InsertionDeviceEnergy attributes to public#1966

Open
oliwenmandiamond wants to merge 3 commits intomainfrom
update_id_energy_attributes_to_be_public
Open

Update InsertionDeviceEnergy attributes to public#1966
oliwenmandiamond wants to merge 3 commits intomainfrom
update_id_energy_attributes_to_be_public

Conversation

@oliwenmandiamond
Copy link
Contributor

In reference to https://github.com/DiamondLightSource/sm-bluesky/pull/100/changes, a plan is trying to access private members. Update these to public.

Instructions to reviewer on how to test:

  1. Check tests pass

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@oliwenmandiamond oliwenmandiamond requested a review from a team as a code owner March 10, 2026 09:22
@codecov
Copy link

codecov bot commented Mar 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.11%. Comparing base (664403b) to head (5c37aac).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1966   +/-   ##
=======================================
  Coverage   99.11%   99.11%           
=======================================
  Files         318      318           
  Lines       12331    12331           
=======================================
  Hits        12222    12222           
  Misses        109      109           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant