Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1989 +/- ##
=======================================
Coverage 99.11% 99.11%
=======================================
Files 318 318
Lines 12336 12354 +18
=======================================
+ Hits 12227 12245 +18
Misses 109 109 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
DominicOram
left a comment
There was a problem hiding this comment.
Thanks, just the one comment but happy to merge once you've addressed. I think we can do some work in combining all these shutters/interlocks down but hopefully that will fallout of #651
src/dodal/devices/hutch_shutter.py
Outdated
|
|
||
| # TODO replace with read | ||
| # See https://github.com/DiamondLightSource/dodal/issues/651 | ||
| # TODO check if shutter only opens when Ilks are "OK" or if "Run Ilks Ok" is also healthy |
There was a problem hiding this comment.
Should: Can we either check this before merge or make an issue to track that we need to check it?
There was a problem hiding this comment.
Ah whoops - I did check and updated the docstring, but forgot to remove the note! I'll do that
Fixes #7
Instructions to reviewer on how to test:
dodal connect i15-1hutch_shutterconnectsChecks for reviewer
dodal connect ${BEAMLINE}