Skip to content

Add I15-1 interlocked hutch shutter#1989

Merged
EmsArnold merged 6 commits intomainfrom
ea/add_i15-1_hutch_shutter
Mar 27, 2026
Merged

Add I15-1 interlocked hutch shutter#1989
EmsArnold merged 6 commits intomainfrom
ea/add_i15-1_hutch_shutter

Conversation

@EmsArnold
Copy link
Copy Markdown
Contributor

Fixes #7

Instructions to reviewer on how to test:

  1. Do dodal connect i15-1
  2. Confirm hutch_shutter connects

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.11%. Comparing base (856994d) to head (b6ead82).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1989   +/-   ##
=======================================
  Coverage   99.11%   99.11%           
=======================================
  Files         318      318           
  Lines       12336    12354   +18     
=======================================
+ Hits        12227    12245   +18     
  Misses        109      109           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@EmsArnold EmsArnold marked this pull request as ready for review March 27, 2026 10:36
@EmsArnold EmsArnold requested a review from a team as a code owner March 27, 2026 10:36
@EmsArnold EmsArnold requested a review from noemifrisina March 27, 2026 10:37
Copy link
Copy Markdown
Contributor

@DominicOram DominicOram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just the one comment but happy to merge once you've addressed. I think we can do some work in combining all these shutters/interlocks down but hopefully that will fallout of #651


# TODO replace with read
# See https://github.com/DiamondLightSource/dodal/issues/651
# TODO check if shutter only opens when Ilks are "OK" or if "Run Ilks Ok" is also healthy
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should: Can we either check this before merge or make an issue to track that we need to check it?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah whoops - I did check and updated the docstring, but forgot to remove the note! I'll do that

@EmsArnold EmsArnold merged commit 196af4f into main Mar 27, 2026
10 checks passed
@EmsArnold EmsArnold deleted the ea/add_i15-1_hutch_shutter branch March 27, 2026 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

i15-1: Add hutch shutter (including interlocks)

2 participants