Fix electron analyser regions not accepting field names#1995
Open
oliwenmandiamond wants to merge 9 commits intomainfrom
Open
Fix electron analyser regions not accepting field names#1995oliwenmandiamond wants to merge 9 commits intomainfrom
oliwenmandiamond wants to merge 9 commits intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1995 +/- ##
==========================================
- Coverage 99.11% 99.11% -0.01%
==========================================
Files 318 318
Lines 12361 12359 -2
==========================================
- Hits 12252 12250 -2
Misses 109 109 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Villtord
reviewed
Mar 27, 2026
tests/devices/electron_analyser/vgscienta/test_vgscienta_region.py
Outdated
Show resolved
Hide resolved
Contributor
|
Tests |
Contributor
Author
are you sure it isn't something to do with your env? I can't replicate and is fine for me |
Contributor
|
yes it was old container image, gone after rebuild. |
…' of ssh://github.com/DiamondLightSource/dodal into Fix_electron_analyser_regions_not_accepting_field_names
Villtord
reviewed
Mar 27, 2026
|
|
||
| class AbstractBaseSequence( | ||
| class BaseSequence( | ||
| ABC, |
Contributor
There was a problem hiding this comment.
remove ABC if it is not abstract anymore?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1994
Instructions to reviewer on how to test:
Checks for reviewer
dodal connect ${BEAMLINE}