Skip to content

Pass the plugins on from i22's detectors#2077

Open
DominicOram wants to merge 1 commit into
mainfrom
correctly_add_stats_plugins
Open

Pass the plugins on from i22's detectors#2077
DominicOram wants to merge 1 commit into
mainfrom
correctly_add_stats_plugins

Conversation

@DominicOram
Copy link
Copy Markdown
Contributor

From testing on i22 we found that the stats plugin wasn't actually getting associated with the detectors. This passes it on properly. This was also masking the issue in bluesky/ophyd-async#1278

Instructions to reviewer on how to test:

  1. Run dodal connect i22 on this branch and confirm it fails
  2. Switch over your ophyd-async to use Only use the RBV PV for the read only signals in the stats plugin bluesky/ophyd-async#1278, confirm dodal connect passes

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@DominicOram DominicOram requested a review from a team as a code owner May 29, 2026 17:04
@codecov
Copy link
Copy Markdown

codecov Bot commented May 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.14%. Comparing base (f787f83) to head (c0825d5).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2077   +/-   ##
=======================================
  Coverage   99.14%   99.14%           
=======================================
  Files         341      341           
  Lines       13287    13287           
=======================================
  Hits        13173    13173           
  Misses        114      114           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant