DO NOT MERGE by Oli-Jones475 · Pull Request #3 · DiamondLightSource/fastcs-bacnet

Oli-Jones475 · 2026-04-16T11:51:29Z

This is not an actual PR its just to experiment with GitHub testing

Maybe theres a better way to do this?

I dont really want to create another repository as I need to see how this interacts with BAC0 and FastCS and my classes that use them

A note has been added for the typeignores

Added verification of CoV requests as well

Prepare status object for a race or no race

Used to check whether other team subscription was still up and then queue resubscribe task in lifetime // 2 lifetime //2 would put it in phase with the other teams subscription If you check at subscription fail time the other team could still fail their next subscription, leaving you to do 2 unecessary retrys

Example files (at least low_cpu_stress_test) were being imported when running pytest. Since thye had no if __name__ == "__main__": assertion they were being run. These run indefinitely, breaking the pytest

Has an outline of how system testing should run Doesnt work yet

codecov · 2026-04-20T15:42:43Z

Codecov Report

❌ Patch coverage is 41.17647% with 290 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@b80b94b). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
src/fastcs_bacnet/practical/BAC0/cov_tracker.py	25.88%	63 Missing ⚠️
src/fastcs_bacnet/dummy/BAC0/device.py	25.86%	43 Missing ⚠️
...astcs_bacnet/practical/BAC0/subscription_status.py	51.92%	25 Missing ⚠️
.../fastcs_bacnet/practical/generic/callback_stack.py	43.58%	22 Missing ⚠️
...cs_bacnet/practical/FastCS/bacnet_subcontroller.py	48.71%	20 Missing ⚠️
...astcs_bacnet/practical/BAC0/object_subscription.py	48.57%	18 Missing ⚠️
...ice_variables/puppet_variable/puppet_controller.py	38.46%	16 Missing ⚠️
...y/generic/device_variables/oscillating_variable.py	37.50%	15 Missing ⚠️
src/fastcs_bacnet/practical/BAC0/bacnet_client.py	42.30%	15 Missing ⚠️
.../dummy/generic/device_variables/random_variable.py	38.09%	13 Missing ⚠️
... and 6 more

Additional details and impacted files

@@           Coverage Diff           @@
##             main       #3   +/-   ##
=======================================
  Coverage        ?   42.57%           
=======================================
  Files           ?       18           
  Lines           ?      505           
  Branches        ?        0           
=======================================
  Hits            ?      215           
  Misses          ?      290           
  Partials        ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Oli-Jones475 added 30 commits March 25, 2026 14:50

abstract device variable class written

4af2723

constant variable class created

7585807

Oscillating variable class created

8f08f55

oscillating update loop implemented

b675627

Typo: Refresh rate changed to refresh period

66c6677

random variable class created

87e6fda

random update loop implemented

cbc23b2

read write variable class created

412327b

docstrings written for device_variable

8a242b2

docstrings written for constant_variable

0773f82

docstrings written for oscillating_variable

b1734f1

bug fix: oscillating variable equation accounts for PI

8e99de0

docstring added for random_variable

e551308

Methods in oscillating and random variable set to private

448779a

docstring written for read_write_variable

3bfa750

generic device class created

a91ef0b

device variable initialisation written

5ae4b43

docstrings added for device class

5e4961f

device name stored in generic device

f564615

bacnet object class created

a421316

Added device variable to mimic to bacnet object

1c2f427

docstrings added to analog_output_object

651f7e0

bacnet device class started

1362682

created add object loop in device

a7e5710

docstrings added for the dummy bacnet device

e43c8f3

privated some variables on device

a489799

polling device controller class started

bb1c5ed

device variables made private, getter for name

f140542

device variables converted to dictionary

2acad71

Added variable getter methods to device

f45eed2

Oli-Jones475 added 28 commits April 17, 2026 13:43

Update object_subscription to use callback_stack

58de52c

Implement callback stack in device_variable

45b1576

Implement callback_stack in device_variable

de0ae48

A note has been added for the typeignores

Implement callback_stack in all children

cf226c6

Make subscription status class

2653d4e

Start CovTracker class

4a303ac

Add lifetime attribute to subscription_status

f5e536c

Add lock to subscription_status

e213a71

Add team related functions

f6cfd6c

Implement callback race method

80d1b2a

Implement start_cov method

9b42be7

Added verification of CoV requests as well

Make subscription_status methods more versatile

6da62a7

Implement on resubscribe method

9cc158d

Implement stop_cov method

e86f694

Update set_team_up method

293aa86

Prepare status object for a race or no race

Set status when subscription confirmation is recieved

a33ad6a

Update object_subscription to use cov_tracker

973ee3e

Update object_subscription docstrings

c7178b7

Clean up previous CoV task when resubscribing

d331dc2

Add docstrings to cov_tracker

6eff3d4

Add docstrings to subscription_status

9fcd49f

Test git tests

bbd79b9

Add main assertion to example files

19aec8f

Example files (at least low_cpu_stress_test) were being imported when running pytest. Since thye had no if __name__ == "__main__": assertion they were being run. These run indefinitely, breaking the pytest

Make IP and Port optional in dummy device

0b84352

Remove test tests

3a1d89d

Copy conftest method from PythonSoftIOC

e1975ec

Add a system test file

c0498c3

Has an outline of how system testing should run Doesnt work yet

Oli-Jones475 force-pushed the tests branch from 1b88cf8 to c0498c3 Compare April 20, 2026 15:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DO NOT MERGE#3

DO NOT MERGE#3
Oli-Jones475 wants to merge 213 commits into
mainfrom
tests

Oli-Jones475 commented Apr 16, 2026

Uh oh!

codecov Bot commented Apr 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

Oli-Jones475 commented Apr 16, 2026

Uh oh!

codecov Bot commented Apr 20, 2026

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant