Skip to content

feat: allow multiple aliases per fastcs PV in CA transport - #421

Draft
shihab-dls wants to merge 7 commits into
add_enum_mappingfrom
allow_multiple_aliases
Draft

feat: allow multiple aliases per fastcs PV in CA transport#421
shihab-dls wants to merge 7 commits into
add_enum_mappingfrom
allow_multiple_aliases

Conversation

@shihab-dls

@shihab-dls shihab-dls commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

During beamline testing, we found that a single fastcs PV may need to be aliased to multiple PVs for GDA support. This PR allows aliases to be passed in as str, EnumMapping, list[str], or [list[EnumMapping].

@coderabbitai

coderabbitai Bot commented Sep 3, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@shihab-dls
shihab-dls changed the base branch from main to add_enum_mapping September 3, 2026 10:30
@codecov

codecov Bot commented Sep 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.53%. Comparing base (9133573) to head (e7ada60).

Additional details and impacted files
@@                 Coverage Diff                  @@
##           add_enum_mapping     #421      +/-   ##
====================================================
+ Coverage             91.49%   91.53%   +0.03%     
====================================================
  Files                    72       72              
  Lines                  3034     3047      +13     
====================================================
+ Hits                   2776     2789      +13     
  Misses                  258      258              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@shihab-dls shihab-dls changed the title Allow multiple aliases feat: allow multiple aliases per fastcs PV in CA transport Sep 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant