Skip to content

Conversation

@stephen-riggs
Copy link
Contributor

The role is now redundant as we only use the detector, and the presence of logic around the use of the microscope now causes problems in tomography.

This removes the role entirely, which means the data_directories can become a list rather than a dictionary.

@codecov
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 30.43478% with 16 lines in your changes missing coverage. Please review.

Project coverage is 27.83%. Comparing base (f99070b) to head (7810e26).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #412      +/-   ##
==========================================
+ Coverage   27.77%   27.83%   +0.06%     
==========================================
  Files          72       72              
  Lines        9883     9842      -41     
  Branches     1318     1305      -13     
==========================================
- Hits         2745     2740       -5     
+ Misses       7044     7012      -32     
+ Partials       94       90       -4     

Copy link
Contributor

@tieneupin tieneupin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very thorough job. It looks like all instances of data_directories and role were caught.

@stephen-riggs stephen-riggs merged commit 733c9b0 into main Nov 29, 2024
17 checks passed
@stephen-riggs stephen-riggs deleted the no-role branch November 29, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants