0.10.1: pin mobile writing stage to visual viewport - #12
Open
Digidai wants to merge 1 commit into
Open
Conversation
Stop iPhone Safari from sliding the paper: lock only html.editor-stage with top/height from visualViewport (no inset:0), write --app-offset-top, overlay the hint, and keep pan-y on the textarea alone. Co-authored-by: Gene Dai <Digidai@users.noreply.github.com>
Digidai
marked this pull request as ready for review
August 17, 2026 13:04
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
cursor Bot
pushed a commit
that referenced
this pull request
Aug 17, 2026
Co-authored-by: Gene Dai <Digidai@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tighten Writer 0.10.0’s locked mobile writing stage. The model stays the same; this fixes the iPhone Safari slide.
html.editor-stageto the visual viewport:top: var(--app-offset-top)+height: var(--app-height). Do not useinset: 0/bottom: 0(that boxed the layout viewport and left a chrome band the paper could slide through).syncViewportMetricsnow writes both--app-height = round(vv.height)and--app-offset-top = round(vv.offsetTop)(0 if novisualViewport).position: fixedroot (height: 100%; overflow: hidden)..deskstaysabsolute; inset: 0inside the stage.touch-action: none. Only.inputispan-y+overscroll-behavior: contain. Documenttouchmoveis cancelled unless the target is the textarea, a button, or a link.public/index.htmlsets the viewport CSS vars beforestyle.csspaints..desk(position: absolute; bottom: 8px) so it no longer steals paper height. Completion bar stays in-flow and only when visible ([hidden])..wellmargin inset. Desktop A4 1123px, archive/settings/reader scrolling, and completion/hint copy rules are unchanged.Version 0.10.1 (
package.json, lockfile,src/version.js, changelog,?v=0.10.1cache-bust).Testing
node --test test/mobile-editor-ui.test.jsnpm testnpm run checkDo not merge or deploy from this PR.