Skip to content

Force reinterpret-cast to reverse the cast in FunctionDefinition.semantic #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
s-ludwig merged 4 commits into from
Mar 3, 2026
+12 −3
Merged

Force reinterpret-cast to reverse the cast in FunctionDefinition.semantic #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
13e3686
Force reinterpret-cast to reverse the cast in FunctionDefinition.sema…
s-ludwig Mar 3, 2026
7d7292c
Use newer upload-artifact version.
s-ludwig Mar 3, 2026
950131f
Patch python update related error in the test suite.
s-ludwig Mar 3, 2026
72edb24
Bump nuber of passed tests up to 5239.
s-ludwig Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ jobs:
run: ./run-test262.sh

- name: Upload log
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
if: always()
with:
name: runtest262 log
Expand Down
2 changes: 1 addition & 1 deletion engine/source/dmdscript/expression.d
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -608,7 +608,7 @@ class FunctionLiteral : Expression

override Expression semantic(Scope *sc)
{
func = cast(FunctionDefinition)(func.semantic(sc));
func = cast(FunctionDefinition)cast(void*)func.semantic(sc);
return this;
}

Expand Down
2 changes: 1 addition & 1 deletion run-test262.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ cd test262-harness-py
python3 src/test262.py --summary --non_strict_only --command ../timed-dmdscript.sh --tests=../test262 | tee ../dmdscript-test262.log | grep -a '=== .* failed in .* ==='
cd ..

EXPECTED_TO_PASS=5238
EXPECTED_TO_PASS=5239
PASSED=$(grep -a ' - Passed [0-9]* tests' dmdscript-test262.log | sed -n 's/.*Passed \([0-9]*\) tests.*/\1/;P')

if [ "$PASSED" -gt "$EXPECTED_TO_PASS" ]; then
Expand Down
9 changes: 9 additions & 0 deletions test262-patches/test262-parseTestRecord.py.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,15 @@ diff --git "a/src/parseTestRecord.py" "b/src/parseTestRecord.py"
index 22d5664..5be3a5f 100644
--- "a/src/parseTestRecord.py"
+++ "b/src/parseTestRecord.py"
@@ -16,7 +16,7 @@
import sys
import tempfile
import time
-import imp
+import importlib

from _monkeyYaml import load as yamlLoad

@@ -78,7 +78,7 @@ def yamlAttrParser(testRecord, attrs, name):
parsed = yamlLoad(body)

Expand Down