anyrender_skia: convert DynamicColor to sRGB before creating SkColor4f#48
Open
jrmoulton wants to merge 1 commit intoDioxusLabs:mainfrom
Open
anyrender_skia: convert DynamicColor to sRGB before creating SkColor4f#48jrmoulton wants to merge 1 commit intoDioxusLabs:mainfrom
jrmoulton wants to merge 1 commit intoDioxusLabs:mainfrom
Conversation
color4f_from_dynamic_color was treating DynamicColor.components as if they were already RGBA channel values. That is only correct for RGB-family color spaces. For colors tagged as HSL, HWB, Lab, Oklab, and similar spaces, those components represent color-space-specific coordinates, not red/green/blue. Convert DynamicColor through to_alpha_color::<Srgb>() before constructing SkColor4f so Skia receives actual RGBA values. This fixes gradients and other paint paths that use non-RGB dynamic colors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
color4f_from_dynamic_color was treating DynamicColor.components as if they were already RGBA channel values. That is only correct for RGB-family color spaces. For colors tagged as HSL, HWB, Lab, Oklab, and similar spaces, those components represent color-space-specific coordinates, not red/green/blue.