anyrender_skia: size render_to_vec buffers before wrapping pixels#49
Open
jrmoulton wants to merge 1 commit intoDioxusLabs:mainfrom
Open
anyrender_skia: size render_to_vec buffers before wrapping pixels#49jrmoulton wants to merge 1 commit intoDioxusLabs:mainfrom
jrmoulton wants to merge 1 commit intoDioxusLabs:mainfrom
Conversation
SkiaImageRenderer::render_to_vec currently assumes the caller has already resized the Vec to the exact pixel buffer size. When callers pass an empty Vec with only capacity reserved, wrap_pixels receives an empty slice and the renderer panics. Resize the Vec to image_info.compute_min_byte_size() before wrapping it so offscreen rendering works with a plain empty Vec.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SkiaImageRenderer::render_to_vec currently assumes the caller has already resized the Vec to the exact pixel buffer size. When callers pass an empty Vec with only capacity reserved, wrap_pixels receives an empty slice and the renderer panics.
Resize the Vec to image_info.compute_min_byte_size() before wrapping it so offscreen rendering works with a plain empty Vec. This keeps the unwrap that follows safe