Skip to content

fix: include base_path in dev-server websocket URL#5594

Open
mvanhorn wants to merge 1 commit into
DioxusLabs:mainfrom
mvanhorn:fix/osc-fix-include-basepath-in-dev-server-webso
Open

fix: include base_path in dev-server websocket URL#5594
mvanhorn wants to merge 1 commit into
DioxusLabs:mainfrom
mvanhorn:fix/osc-fix-include-basepath-in-dev-server-webso

Conversation

@mvanhorn

Copy link
Copy Markdown

Summary

fix: include base_path in dev-server websocket URL

Closes #5584


AI was used for assistance.

@mvanhorn mvanhorn requested a review from a team as a code owner May 27, 2026 13:50

@NoeTerrier NoeTerrier left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix !

I have two questions tho:

  1. What were the reasons behind the changes made to the “package/cli” directory in connection with this issue?
  2. Just to address a general question I have: when building for release, is the hot reloading expected at all? 🤔

@mvanhorn mvanhorn force-pushed the fix/osc-fix-include-basepath-in-dev-server-webso branch from 12ab481 to c4fef5f Compare May 28, 2026 04:18
@mvanhorn

Copy link
Copy Markdown
Author

Good catch. The packages/cli change (and a small fullstack-core response-header tweak) were unrelated to this fix and got bundled in by mistake — I've stripped the branch down to just the websocket URL change, so the PR is now a single file (packages/web/src/devtools.rs). Those other bits were standalone improvements and can come back as their own focused PRs.

On the release question: make_ws only connects to the dev server's /_dioxus endpoint, which is served by dx serve. Release builds don't run that dev server, so there's nothing for it to connect to — hot reloading isn't expected in release. This base_path change only matters for dx serve sitting behind a proxy under a sub-path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dioxus websocket request doesn't include base_path

2 participants