test(count): -1 means unknown, and nothing was holding it there - #16
Merged
Merged
Conversation
The gate found six survivors, all the same one: `return -1` in the three places that read the count through an optional interface. Mutated to 0 or -2, every test still passed. It is not a cosmetic constant. Zero means "the scope produced nothing to judge", which RunChanged now treats as nothing to do -- so a decorator that answered 0 for "I could not tell" would turn every genuinely failing run behind it into a silent success. That is the exact defect the empty-scope fix was written to avoid, reintroduced one layer down. Pinned in both places: the release's own reader over a reporter that cannot count, and each decorator over one. The negative sentinel is deliberate and now says so -- a count cannot be negative, so no real answer collides with it.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The gate found six survivors on the previous merge, all the same one:
return -1in the three places that read the count through an optionalinterface. Mutated to
0or-2, every test still passed.It is not a cosmetic constant. Zero means the scope produced nothing to judge,
which
RunChangednow treats as nothing to do — so a decorator answering0for "I could not tell" would turn every genuinely failing run behind it into a
silent success. That is the exact defect the empty-scope fix was written to
avoid, reintroduced one layer down.
Pinned in both places now: the release's own reader over a reporter that cannot
count, and each decorator over one. The negative sentinel is deliberate and the
tests say why — a count cannot be negative, so no real answer collides with it.
No production code changed.