-
Notifications
You must be signed in to change notification settings - Fork 1
[Fix] 중복 요청 시 동일 Event ID를 반환하도록 Outbox 멱등성 보장 #174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+587
−34
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
payload 전체 일치 비교가
DOCUMENT_VERSION_CREATED에서 정상 재시도를 실패로 만듭니다.recordDocumentVersionCreated의 idempotency key는DOCUMENT_VERSION:{id}:DOCUMENT_VERSION_CREATED:{versionNo}입니다.embeddingModelId는 key에 없고 payload에만 있습니다. 따라서 active embedding model이 바뀐 뒤 동일 version에 대한 재시도가 들어오면 key는 같고 payload는 달라져SYNC_EVENT_INCONSISTENT가 발생합니다. 이때 호출 흐름(문서 업로드)이 실패합니다.두 가지 해석이 가능합니다.
embeddingModelId를 포함해야 합니다.recordDocumentReindexRequested는 이미 model id를 key에 포함하므로 이 방향이 일관됩니다.의도한 해석을 확정하세요.
♻️ 해석 2를 선택할 경우의 변경안
이 변경은
SyncEventWriterTest의 기대 key 문자열과 통합 테스트의 key 조립부도 함께 수정해야 합니다.🤖 Prompt for AI Agents