Fix development logs being wrapped when LogStruct is disabled #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The TaggedLogging formatter monkey patch was unconditionally wrapping
all string log messages in hashes, even when LogStruct was disabled.
This caused development logs to appear as {message: "..."} instead of
plain text.
Added an early return check to preserve original Rails logging behavior
when LogStruct is disabled.
Fixes #1
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
LogStruct.enabled?before wrapping messages in hashesProblem
When adding the LogStruct gem to a Rails 8.1 app without any configuration, development logs were appearing as
{message: "..."}instead of plain text. This was because theFormatterExtensionmonkey patch was unconditionally wrapping all string messages in hashes, regardless of whether LogStruct was enabled.Solution
Added an early return check in the
FormatterExtension#callmethod to skip hash wrapping when LogStruct is disabled, preserving the original Rails logging behavior in development.Test plan
Fixes #1
🤖 Generated with Claude Code