[lmjabreu]

Overview

UserStatusSchema (added in #100) required effects.pauseNotifications.scope.mode. A Status can be written by other Todoist clients through user_update, and comms-ios decodes PauseNotifications as an empty struct, so a stored pause_notifications: {} is plausible. The backend omits unset fields on this route, so scope can come back absent and getSessionUser / getUser throw a ZodError for every caller. scope and scope.mode are now optional. SetStatusArgs is unchanged.

Reference

Found in the review of Doist/comms-cli#77, which reproduced the crash with a fake server returning effects: {pause_notifications: {}}.

Backend, read from main of Doist/comms-backend with gh api (not run):

• get_session_user is declared with response_model_exclude_unset=True (twist/domains/users/api.py).
• PauseNotificationsEffect.scope is filled by default_factory (twist/models/dto/users.py), so a scope that was never set is not serialised.

Not verified: where the stored status is turned into UserStatus on the read path. I looked in twist/models/user_views.py and user_profile.py and did not find it, so I don't know whether the DTO is built by validation or by construction. If it is built by validation, the default would count as set and scope would come back as {"mode": "all"}. Nothing was run against a real backend, so whether {} actually reaches the SDK without scope is still unconfirmed. The change is safe either way, since it only loosens parsing.

Changelog

Fix a crash when reading a user whose status pauses notifications without a scope.

Test plan

1. On main, run npx vitest run src/clients/users-client.test.ts. The new test "parses a pause_notifications effect stored without a scope" fails with a ZodError.

• On this branch the same command passes, along with npm test, npm run type-check and npm run check.

🤖 Generated with Claude Code

[lmjabreu]

@doistbot /review

[doistbot]

This PR updates fix: accept a pause_notifications effect without a scope. No issues were flagged in the reviewed diff.

_{Share Feedback • Review Logs}

[doist-release-bot]

🎉 This PR is included in version 3.4.1 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀