Skip to content

chore(deps): update dependency eslint to v10 #1164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
renovate wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore(deps): update dependency eslint to v10 #1164

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@
"classnames": "2.5.1",
"conventional-changelog-conventionalcommits": "10.2.1",
"cssnano": "8.0.5",
"eslint": "8.57.1",
"eslint": "10.8.1",

@doistbot doistbot Aug 17, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 ESLint 10 only supports flat config (eslint.config.js). This repo has no flat config; .eslintrc extends legacy @doist/eslint-config/eslintrc/* paths and the lint script still invokes eslint the old way, so npm run lint (and validate, plus the pre-commit hook) will fail after this bump. Migrate to eslint.config.js (the flat-config equivalents of the @doist/eslint-config presets) as part of this upgrade.

@doistbot doistbot Aug 17, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 package-lock.json still pins eslint to 8.57.1 (both the root devDependencies entry and node_modules/eslint). The bump is therefore incomplete: npm ci will fail with an out-of-sync lockfile (or install 8.57.1), so the version in package.json never takes effect. Regenerate the lockfile as part of this change.

"eslint-config-prettier": "^8.5.0",
"eslint-formatter-codeframe": "^7.32.1",
"eslint-plugin-jest": "28.14.0",
Expand Down
Loading