fix(deps): update dependency @doist/todoist-sdk to v14 - #477
fix(deps): update dependency @doist/todoist-sdk to v14#477renovate[bot] wants to merge 1 commit into
Conversation
f979eb1 to
87ed3b9
Compare
doistbot
left a comment
There was a problem hiding this comment.
This is a straightforward Renovate dependency bump from @doist/todoist-sdk 13.0.2 to 14.0.0, but the breaking changes in v14 remove two fields the CLI still actively consumes.
Few things worth tightening:
src/commands/project/health.ts:40-44still readshealth.taskRecommendations, which v14 removes fromgetProjectHealth()— this will breaktype-checkandbuildin CI. Remove that block and update the correspondingproject healthtest mocks.src/commands/workspace/workspace.test.tsstill includesfolderIdin inline mock objects (lines 650, 681, 698) and assertsfolderId: nullin the--jsontest (line 746), but v14 dropsfolderIdfrom thegetWorkspaceInsightsresponse — these mocks and assertions need updating to avoid excess-property type errors and failing tests.
| "dependencies": { | ||
| "@doist/cli-core": "1.1.0", | ||
| "@doist/todoist-sdk": "13.0.2", | ||
| "@doist/todoist-sdk": "14.0.0", |
There was a problem hiding this comment.
v14.0.0 removes
taskRecommendations from getProjectHealth()'s return type (release notes: "drop ... health task recommendations"), but src/commands/project/health.ts:40-44 still reads health.taskRecommendations. npm run type-check and npm run build (both run in CI) will fail with TS2339. Remove the recommendations block from health.ts and update the project health tests that still mock taskRecommendations.
| "dependencies": { | ||
| "@doist/cli-core": "1.1.0", | ||
| "@doist/todoist-sdk": "13.0.2", | ||
| "@doist/todoist-sdk": "14.0.0", |
There was a problem hiding this comment.
v14's breaking change "drop workspace insight folder ID" removes
folderId from the getWorkspaceInsights response, but src/commands/workspace/workspace.test.ts:650,681,698 still include folderId in inline mockResolvedValue object literals (excess-property type error) and the --json test at line 746 still asserts folderId: null in the output, which the SDK no longer returns. Update these mocks/assertions.
87ed3b9 to
9f945e2
Compare
This PR contains the following updates:
13.0.2→14.0.0Release Notes
Doist/todoist-sdk-typescript (@doist/todoist-sdk)
v14.0.0Compare Source
⚠ BREAKING CHANGES
Bug Fixes
Configuration
📅 Schedule: (UTC)
* * * * 1-5)🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.