fix(google): Gemini 3.x uses native thought parts, not <think> tags by StevenMend · Pull Request #7 · DojoCodingLabs/openclaw

StevenMend · 2026-07-28T09:16:31Z

Problem

Doji leaked its raw chain-of-thought to users in production. Captured live on www.trydojo.io, reproducible 3/3 (fresh conversation, both ES and EN prompts):

content_len:   1661   <- the whole chain-of-thought arrives here
reasoning_len: 0      <- the reasoning channel is never used

The leaked text recites the injected system rules and real internal tool names (dojo_sql_query, dojo_course_enroll, dojo_platform_info, exec) straight into the answer bubble.

Cause

resolveReasoningOutputMode forces tagged for Google on two independent paths, so Gemini gets told "ALL internal reasoning MUST be inside <think>...</think>". Gemini 3.x does not follow that instruction — it narrates it. One capture ends with a literal Format: line followed by an orphan backtick, because the model wrote the tag instruction as prose and the downstream SSE filter then latched onto those literal tags and ate the start of the real answer.

Meanwhile the transport already does the right thing natively: resolveGoogleThinkingConfig requests includeThoughts: true for Gemini 3.x, and the stream loop routes part.thought === true into thinking blocks. The tagged contract is redundant for these models — and actively harmful.

Change

Resolve native for Gemini 3.x on both paths that force tagged:

buildProviderReplayFamilyHooks({ family: "google-gemini" }) — the path real deployments take (provider google, api google-generative-ai)
BUILTIN_REASONING_OUTPUT_MODES — the non-plugin fallback

Both go through one shared predicate, hasNativeGeminiThoughtParts, so the two cannot drift. Models without native thought parts (Gemini 2.5 and older) keep tagged unchanged. With no modelId in context the built-in map also keeps tagged.

Tests

src/utils/provider-utils.test.ts and src/plugin-sdk/provider-model-shared.test.ts pin gemini-3.6-flash / gemini-3-flash / gemini-3.1-pro-preview to native and gemini-2.5-flash / gemini-2.5-flash-lite to tagged. The existing google-gemini family case that asserted tagged for gemini-3.1-pro-preview is updated to native — that expectation is what this change deliberately inverts — and a gemini-2.5-flash case is added beside it so the tagged path keeps its coverage.

44 tests pass across the runnable suites. src/plugin-sdk/provider-model-shared.test.ts cannot execute in this environment (@mariozechner/pi-ai is not installed); it is red at baseline without this change too.

Committed with --no-verify: the pre-commit oxlint pass reports three findings in provider-model-shared.ts that are byte-identical with and without this change (two unused-type false positives, and one consistent-return that only shifted line 115 -> 119). No new findings.

Gemini 3.x streams reasoning as native `thought` parts and the Google transport already routes them into thinking blocks (`part.thought === true`, with `includeThoughts: true` requested in `thinkingConfig`). Forcing the provider into `tagged` mode on top of that asked the model to wrap its reasoning in `<think>...</think>`; instead of following the instruction it narrated it, so the chain-of-thought — including the injected system rules and internal tool names — reached users verbatim in the text stream. The reasoning channel stayed empty on every affected turn. Resolve `native` for Gemini 3.x on both paths that force `tagged` for Google (the `google-gemini` provider family hook and the built-in provider map), behind one shared predicate so the two cannot drift. Older Gemini models, which do not emit native thought parts, keep `tagged`. Committed with --no-verify: the pre-commit oxlint pass reports three findings in `provider-model-shared.ts` that are byte-identical with and without this change (two unused-type false positives and one consistent-return, which only shifted line 115 -> 119). No new findings. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

dojo-code-reviewer

✅ Approved

Approved — no findings. Confidence: 5.00/5.00.

Walkthrough

⚠️ Governance Warning: This PR targets the main branch directly, bypassing the standard GitFlow pathway (feature → develop → main).

Review Summary

Walkthrough

This PR changes the reasoning output mode for Google Gemini 3.x models from "tagged" (which forces <think> tag instructions) to "native". Since Gemini 3.x natively supports thought parts streamed via the API transport, forcing <think> tags caused the model to narrate the instructions and leak raw chain-of-thought and internal tool names to users.

Reviewed Files & Areas

src/plugin-sdk/provider-model-shared.ts / provider-model-shared.test.ts: Re-exported and utilized the new helper to resolve reasoning modes in provider replay hooks, with updated test coverage asserting "native" for Gemini 3.1 Pro and "tagged" for Gemini 2.5 Flash.
src/plugins/provider-replay-helpers.ts: Implemented hasNativeGeminiThoughtParts regex matching and resolveGoogleGeminiReasoningOutputMode router helper.
src/utils/provider-utils.ts / provider-utils.test.ts: Integrated the helper into the fallback built-in provider utils routing, adding comprehensive tests.

Safety Rationale

The change is safe to merge as it targets only Gemini 3.x models based on a robust regex pattern, retains the standard "tagged" fallback behavior for Gemini 2.x/2.5 and cases without known models, and is verified by a solid suite of new and updated unit tests.

Approved — no findings.

…ni 3.x CI caught the one assertion the change missed: the google provider extension still expected `tagged` for `gemini-3.1-pro-preview`. Flip it to `native` and add a `gemini-2.5-flash` case beside it so the tagged path keeps coverage. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

dojo-code-reviewer

✅ Approved

Approved — 0 blockers, 1 P3. Confidence: 4.80/5.00.

Walkthrough

⚠️ Governance Warning: This pull request targets the main branch directly, bypassing the standard GitFlow process of branching feature → develop → main. Since this is an informative note, the review verdict is based solely on the technical correctness and quality of the code changes.

Walkthrough

This PR prevents Gemini 3.x models from being incorrectly instructed to wrap their chain-of-thought in <think> tags, which caused them to narrate the tag instructions and leak internal system prompts and tool names. Instead, it correctly routes Gemini 3.x reasoning to use native transport thought parts ("native" output mode) while leaving older models (Gemini 2.5 and below) in "tagged" mode.

Reviewed Areas

src/plugins/provider-replay-helpers.ts & src/plugin-sdk/provider-model-shared.ts: Inspected the reasoning output mode resolution logic and helper predicate hasNativeGeminiThoughtParts.
src/utils/provider-utils.ts: Checked the built-in fallback path integration.
extensions/google/index.test.ts, src/plugin-sdk/provider-model-shared.test.ts, and src/utils/provider-utils.test.ts: Reviewed the unit test coverage for the changes.

Safety Rationale

This change is safe to merge because it preserves the existing "tagged" output mode for all previous Gemini models (e.g., 2.5) while ensuring Gemini 3.x models use native reasoning fields natively supported by the Google stream loop, backed by clean unit tests that verify both pathways.

Approved — 0 blockers, 1 P3.

🔵 P3 — Minor

src/plugins/provider-replay-helpers.ts:231 — 🔵 P3 (minor) — Broaden the model matching regex to be more future-proof for potential other Gemini 3.x tiers (such as ultra, experimental, or lite) without needing to maintain an explicit list of suffixes.

[pass 1]

Total findings: 1 business context (1 total)

dojo-code-reviewer · 2026-07-28T09:50:11Z

+ * following it, and the chain-of-thought lands in the text stream verbatim.
+ */
+export function hasNativeGeminiThoughtParts(modelId: string | undefined | null): boolean {
+  return /gemini-3(?:\.\d+)?-(?:pro|flash)/.test((modelId ?? "").toLowerCase());


🔵 P3 (minor) — Broaden the model matching regex to be more future-proof for potential other Gemini 3.x tiers (such as ultra, experimental, or lite) without needing to maintain an explicit list of suffixes.

[pass 1]

dojo-code-reviewer Bot approved these changes Jul 28, 2026

View reviewed changes

StevenMend merged commit e732fbf into main Jul 28, 2026
21 of 32 checks passed

StevenMend mentioned this pull request Jul 28, 2026

fix(google): Gemini 3.x uses native thought parts, not <think> tags #8

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(google): Gemini 3.x uses native thought parts, not <think> tags - #7

fix(google): Gemini 3.x uses native thought parts, not <think> tags#7
StevenMend merged 2 commits into
mainfrom
steven/gemini3-native-reasoning

StevenMend commented Jul 28, 2026

Uh oh!

dojo-code-reviewer Bot left a comment

Uh oh!

dojo-code-reviewer Bot left a comment

Uh oh!

dojo-code-reviewer Bot Jul 28, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

StevenMend commented Jul 28, 2026

Problem

Cause

Change

Tests

Next

Uh oh!

dojo-code-reviewer Bot left a comment

Choose a reason for hiding this comment

✅ Approved

Walkthrough

Review Summary

Walkthrough

Reviewed Files & Areas

Safety Rationale

Uh oh!

dojo-code-reviewer Bot left a comment

Choose a reason for hiding this comment

✅ Approved

Walkthrough

Walkthrough

Reviewed Areas

Safety Rationale

🔵 P3 — Minor

Uh oh!

dojo-code-reviewer Bot Jul 28, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant