fix: filter requests by hostname instead of path#4255
Open
manalkaff wants to merge 1 commit intoDokploy:canaryfrom
Open
fix: filter requests by hostname instead of path#4255manalkaff wants to merge 1 commit intoDokploy:canaryfrom
manalkaff wants to merge 1 commit intoDokploy:canaryfrom
Conversation
The search filter on the Requests tab was incorrectly filtering by RequestPath instead of RequestHost, causing "filter by name" to match URL paths rather than hostnames. Updated the placeholder text to reflect the correct field being searched. Fixes Dokploy#4249
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RequestPath(the URL path) instead ofRequestHost(the hostname)parseRawConfiginpackages/server/src/utils/access-log/utils.tsto filter bylog.RequestHostTest plan
myapp.example.com) in the filter input — results should filter by hostname now/dashboard) no longer matches unrelated hostnamesFixes #4249
Greptile Summary
This PR fixes a bug where the search filter on the Requests tab was incorrectly matching against
RequestPath(the URL path) instead ofRequestHost(the hostname). The server-side filter inparseRawConfigis updated to uselog.RequestHost, and the UI input placeholder is updated from "Filter by name..." to "Filter by hostname..." to match.Confidence Score: 5/5
Safe to merge — a one-line targeted bug fix with no side effects.
RequestHostis confirmed as a valid field in theLogEntrytype, the change is minimal and correct, and the placeholder update accurately reflects the new behavior.No files require special attention.
Reviews (1): Last reviewed commit: "fix: filter requests by hostname instead..." | Re-trigger Greptile