Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR about?
New PR of Reef Chain
This PR updates the Reef Chain templates to the new
stable2512deployment flow and switches all runtime-fetched scripts to the dedicated scripts repository:https://github.com/anukulpandey/dokploy-reef-chain-scriptsIncluded changes
reef-bootnodeto fetch bootstrap/runtime scripts from the new scripts reporeef-validatorto fetch the validator startup script from the new scripts reporeef-rpcto fetch the RPC startup script from the new scripts reporeef-spec-gento fetch the spec generator API and helper scripts from the new scripts reporeef-dev-clusterto stop downloading the old Makefile-based workflow and instead use the new non-tmuxcluster launcher script8545inreef-dev-clusterfor bundledeth-rpcreef-faucettemplatemeta.jsonreef-dokploy-templates-v2raw GitHub pathsWhy this change
This aligns the Reef templates with the newer
stable2512chain workflow and centralizes all runtime scripts in a single dedicated repository so Dokploy services fetch a stable, maintained source at startup.Checklist
Before submitting this PR, please make sure that:
Issues related (if applicable)
Close automatically the related issues using the keywords:
closes #ISSUE_NUMBERScreenshots or Videos
N/A
Greptile Summary
This PR updates all Reef Chain templates to the
stable2512workflow, centralizes runtime scripts in a dedicated external repository, and adds a newreef-faucettemplate. Several structural issues conflict with the project's Docker Compose conventions documented in AGENTS.md and need to be addressed before merging:portsinstead of the requiredexpose, missingrestartpolicy, and most lack the requiredversion: \"3.8\"header.reef-spec-genservice is namedreef-spec-api, breaking the mandatory folder-name match and the domain config in itstemplate.toml.template.tomlfiles hardcode the same validator private-key seeds as default values (includingFAUCET_SEED), violating the "never hardcode secrets" rule.mainbranch of an external repo without hash verification, creating a supply-chain risk.Confidence Score: 3/5
Not safe to merge — multiple P1 violations of documented Dokploy conventions, a service naming mismatch that breaks domain routing, hardcoded validator private-key seeds, and unpinned external script downloads creating supply-chain exposure.
Five P1 findings are present: (1) all templates use
portsinstead of the mandatoryexpose, (2) none have arestartpolicy, (3) five templates omitversion: "3.8"and one uses "3.9", (4) thereef-spec-genservice name mismatch will break its domain config, and (5) hardcoded default private-key seeds across four templates violate the no-secrets rule and introduce a real security risk on any default deployment.All
docker-compose.ymlfiles (ports/restart/version),blueprints/reef-spec-gen/docker-compose.yml(service name), and alltemplate.tomlfiles that hardcode seed values (reef-bootnode,reef-dev-cluster,reef-validator,reef-faucet).Vulnerabilities
reef-bootnode,reef-dev-cluster,reef-validator, andreef-faucetall ship the same three validator seeds as defaulttemplate.tomlvalues. A default deployment controls a live chain with publicly-known signing keys and a known faucet treasury key.anukulpandey/dokploy-reef-chain-scriptson themainbranch at startup with no checksum validation. A compromised or modified push to that repo will silently affect all running deployments on next restart.Reviews (1): Last reviewed commit: "Wire Reef templates to external scripts ..." | Re-trigger Greptile
(3/5) Reply to the agent's comments like "Can you suggest a fix for this @greptileai?" or ask follow-up questions!
Context used: