Open
Conversation
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Author
|
@greptile review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR about?
New PR of Shopware
This PR:
shopwareblueprint withdocker-compose.yml,template.toml, andlogo.svgshopwareentry tometa.jsonnode dedupe-and-sort-meta.jsshopwareChecklist
Before submitting this PR, please make sure that:
Issues related (if applicable)
None.
Screenshots or Videos
Not included.
Greptile Summary
This PR adds a complete Shopware 6 blueprint with a multi-stage init chain (bootstrap → init-permissions → init → runtime services), MySQL 8.4, Redis 7.4, a background worker, and a scheduler. All repo conventions are met: version
3.8, named volumes only,exposeinstead ofports, and the primary service is namedshopwareto match the blueprint folder.The only finding is a minor inconsistency in the
init,shopware,worker, andschedulerentrypoints, which use a bare$for shell command substitutions ($(cat ...)) whilebootstrapcorrectly uses$$to escape the$from Docker Compose's variable interpolation engine. In practice this works on current Docker Compose v2, but the$$form is the guaranteed-safe approach.Confidence Score: 5/5
$vs$$inconsistency that works correctly on all current Docker Compose v2 releases.Reviews (2): Last reviewed commit: "fix: address remaining shopware review n..." | Re-trigger Greptile