Add SMTP_PORT environment variable to docker-compose#806
Add SMTP_PORT environment variable to docker-compose#806shgxz wants to merge 1 commit intoDokploy:mainfrom
Conversation
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
| NEXT_PUBLIC_VIEWER_URL: '${NEXT_PUBLIC_VIEWER_URL}' | ||
| ADMIN_EMAIL: '${ADMIN_EMAIL}' | ||
| SMTP_HOST: '${SMTP_HOST}' | ||
| SMTP_PORT: ${SMTP_PORT} |
There was a problem hiding this comment.
Inconsistent quoting on
SMTP_PORT
Every other env var in this file wraps its value in single quotes (e.g. '${SMTP_HOST}'), but SMTP_PORT is unquoted. While port numbers are safe without quotes, the inconsistency is worth fixing. Without quotes, an unset variable also produces a bare SMTP_PORT: line, which some parsers treat differently than an empty string.
Same applies to line 46 in the typebot-viewer service.
| SMTP_PORT: ${SMTP_PORT} | |
| SMTP_PORT: '${SMTP_PORT}' |
| NEXT_PUBLIC_VIEWER_URL: '${NEXT_PUBLIC_VIEWER_URL}' | ||
| ADMIN_EMAIL: '${ADMIN_EMAIL}' | ||
| SMTP_HOST: '${SMTP_HOST}' | ||
| SMTP_PORT: ${SMTP_PORT} |
There was a problem hiding this comment.
Inconsistent quoting on
SMTP_PORT (viewer service)
Same quoting inconsistency as in typebot-builder — should use single quotes to match all other variables in the file.
| SMTP_PORT: ${SMTP_PORT} | |
| SMTP_PORT: '${SMTP_PORT}' |
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
What is this PR about?
Due to SMTP_PORT not mentioned in docker compose file, emails were not being sent.
New PR of [Template Name]
Checklist
Before submitting this PR, please make sure that:
Issues related (if applicable)
Close automatically the related issues using the keywords:
closes #ISSUE_NUMBERScreenshots or Videos
Greptile Summary
Adds the missing
SMTP_PORTenvironment variable to bothtypebot-builderandtypebot-viewerservices in the Typebot docker-compose. The variable was already declared intemplate.tomlwith a default value of"25", so this change correctly closes the gap that was preventing emails from being sent. The only minor concern is thatSMTP_PORT: ${SMTP_PORT}is unquoted while every other env var in the file uses single-quoted substitution syntax.Confidence Score: 5/5
Safe to merge — the fix is correct and the only findings are minor style inconsistencies.
The change correctly adds the missing SMTP_PORT variable to both services, matching the existing template.toml definition. All remaining comments are P2 style suggestions about quoting consistency that don't affect runtime behavior.
No files require special attention.
Reviews (1): Last reviewed commit: "Add SMTP_PORT environment variable to do..." | Re-trigger Greptile