Skip to content

Add SMTP_PORT environment variable to docker-compose#806

Open
shgxz wants to merge 1 commit intoDokploy:mainfrom
shgxz:patch-1
Open

Add SMTP_PORT environment variable to docker-compose#806
shgxz wants to merge 1 commit intoDokploy:mainfrom
shgxz:patch-1

Conversation

@shgxz
Copy link
Copy Markdown

@shgxz shgxz commented Apr 18, 2026

What is this PR about?

Due to SMTP_PORT not mentioned in docker compose file, emails were not being sent.

New PR of [Template Name]

Checklist

Before submitting this PR, please make sure that:

Issues related (if applicable)

Close automatically the related issues using the keywords: closes #ISSUE_NUMBER

Screenshots or Videos

Greptile Summary

Adds the missing SMTP_PORT environment variable to both typebot-builder and typebot-viewer services in the Typebot docker-compose. The variable was already declared in template.toml with a default value of "25", so this change correctly closes the gap that was preventing emails from being sent. The only minor concern is that SMTP_PORT: ${SMTP_PORT} is unquoted while every other env var in the file uses single-quoted substitution syntax.

Confidence Score: 5/5

Safe to merge — the fix is correct and the only findings are minor style inconsistencies.

The change correctly adds the missing SMTP_PORT variable to both services, matching the existing template.toml definition. All remaining comments are P2 style suggestions about quoting consistency that don't affect runtime behavior.

No files require special attention.

Reviews (1): Last reviewed commit: "Add SMTP_PORT environment variable to do..." | Re-trigger Greptile

Greptile also left 2 inline comments on this PR.

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. template New template request labels Apr 18, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 18, 2026

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
templates ✅ Ready (View Log) Visit Preview b5d7850

NEXT_PUBLIC_VIEWER_URL: '${NEXT_PUBLIC_VIEWER_URL}'
ADMIN_EMAIL: '${ADMIN_EMAIL}'
SMTP_HOST: '${SMTP_HOST}'
SMTP_PORT: ${SMTP_PORT}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Inconsistent quoting on SMTP_PORT

Every other env var in this file wraps its value in single quotes (e.g. '${SMTP_HOST}'), but SMTP_PORT is unquoted. While port numbers are safe without quotes, the inconsistency is worth fixing. Without quotes, an unset variable also produces a bare SMTP_PORT: line, which some parsers treat differently than an empty string.

Same applies to line 46 in the typebot-viewer service.

Suggested change
SMTP_PORT: ${SMTP_PORT}
SMTP_PORT: '${SMTP_PORT}'

NEXT_PUBLIC_VIEWER_URL: '${NEXT_PUBLIC_VIEWER_URL}'
ADMIN_EMAIL: '${ADMIN_EMAIL}'
SMTP_HOST: '${SMTP_HOST}'
SMTP_PORT: ${SMTP_PORT}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Inconsistent quoting on SMTP_PORT (viewer service)

Same quoting inconsistency as in typebot-builder — should use single quotes to match all other variables in the file.

Suggested change
SMTP_PORT: ${SMTP_PORT}
SMTP_PORT: '${SMTP_PORT}'

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files. template New template request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant