domain connect template for uspeedo.com#701
Open
kiritoaurora wants to merge 5 commits intoDomain-Connect:masterfrom
Open
domain connect template for uspeedo.com#701kiritoaurora wants to merge 5 commits intoDomain-Connect:masterfrom
kiritoaurora wants to merge 5 commits intoDomain-Connect:masterfrom
Conversation
|
Linter OK: |
Collaborator
|
Could you reconsider use of https://github.com/Domain-Connect/dc-template-linter/wiki/DCTL1024 |
Author
@kerolasa I have changed the variable %host% to %subdomain%. Is that okay? |
pawel-kow
requested changes
Jan 19, 2026
| { | ||
| "type": "CNAME", | ||
| "groupId": "tracking", | ||
| "host": "%track_host%", |
Member
There was a problem hiding this comment.
is this host under %subdomain%?
If it is the whole template could have used @ instead of %subdomain% and standard host parameter, which has quite benefits - template can be applied several times to the same domain and different subdomains if needed.
Otherwise multiInstance setting might be of help.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
<-- short description of the template(s) and/or reason for update -->
Type of change
Please mark options that are relevant.
How Has This Been Tested?
Please mark the following checks done
<providerId>.<serviceId>.jsonlogoUrlis actually served by a webserverExample variable values
<-- to make review process easier please provide example set of variable values for this template -->
<-- Example: -->
<-- Or provide the whole
testDataobject from the Online Editor after testing and using "Add as test" button -->