clarify 'Host/Name in Template' by adding ascii diagram#104
Open
kerolasa wants to merge 1 commit intoDomain-Connect:masterfrom
Open
clarify 'Host/Name in Template' by adding ascii diagram#104kerolasa wants to merge 1 commit intoDomain-Connect:masterfrom
kerolasa wants to merge 1 commit intoDomain-Connect:masterfrom
Conversation
This update tries to make it really clear 'host' is a key word that exists in two namespaces 1) as a apply parameter, and 2) template value. It would have been nice if these string had been different, but we have what we do and the best in this situation is to try to be as clear and explicit as possible the two 'hosts' are separate but related. Co-authored-with: Jack Holdsworth <jholdsworth@cloudflare.com> Signed-off-by: Sami Kerola <kerolasa@iki.fi>
pawel-kow
requested changes
Sep 17, 2024
| | | ||
| v | ||
| +----------------------------------------+ | ||
| | get domain from template: example.com. | |
Member
There was a problem hiding this comment.
What is the meaning of "get domain from template"? Or is it the domain of apply call (L1964) ?
| | | ||
| v | ||
| +------------------------------+ | ||
| | does template include: host? | |
Member
There was a problem hiding this comment.
This part should be somehow in loop over all the records, shouldn't it?
| +-------------------------+ | | ||
| ^ v | ||
| | +----------------+ | ||
| yes--| is the host: @ | |
Member
There was a problem hiding this comment.
Somewhere in between should be also variable resolution, which can also be in the host field.
| | no | ||
| v | ||
| +-----------------------------+ | ||
| | get host from template: bar | |
Member
There was a problem hiding this comment.
Somehow would be good to be more indicative which part is an algorithm and which one is an example
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update tries to make it really clear 'host' is a key word that exists in two namespaces 1) as a apply parameter, and 2) template value. It would have been nice if these string had been different, but we have what we do and the best in this situation is to try to be as clear and explicit as possible the two 'hosts' are separate but related.
Co-authored-with: Jack Holdsworth jholdsworth@cloudflare.com