feat: improve CJK font rendering with chinese_font_library #722
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integrate chinese_font_library to properly render Chinese, Japanese, and Korean characters across all platforms. Signed-off-by: Dee HY <dongfengweixiao@hotmail.com>
dongfengweixiao
force-pushed
the
fix/cjk
branch
from
0260d7f to
b4a6d1a
Compare
Author
|
PartyDonut
reviewed
Jan 25, 2026
Collaborator
PartyDonut
left a comment
PartyDonut
left a comment
There was a problem hiding this comment.
While the implementation looks ok I do have some questions, see the comments.
| ? FladderTheme.theme(darkDynamic ?? FladderTheme.defaultScheme(Brightness.dark), schemeVariant) | ||
| : FladderTheme.theme(themeColor.schemeDark, schemeVariant)); | ||
|
|
||
| // Apply Chinese font for non-Linux platforms (Windows, macOS, Android, iOS) |
Collaborator
There was a problem hiding this comment.
Why not apply the CJK font for all platforms?
| macos_window_utils: ^1.9.0 | ||
|
|
||
| # Fix cjk font rendering issue on Windows | ||
| chinese_font_library: ^1.2.0 |
Collaborator
There was a problem hiding this comment.
I would prefer to just add additional fonts instead of relying on a external package for this.
Author
There was a problem hiding this comment.
In that case, you would at least need to add fonts for Simplified Chinese, Traditional Chinese, and Japanese, which would lead to a significant increase in the size of the final build. Using chinese_font_library might be the solution with the least side effects.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrate chinese_font_library to properly render Chinese, Japanese, and Korean characters across all platforms.
I don’t have the environment to build and test.
Pull Request Description
Issue Being Fixed
Resolves #493
Screenshots / Recordings
Checklist