Make apply more memory-friendly for CUDA#407
Draft
VidithM wants to merge 2 commits intoDrTimothyAldenDavis:dev2from
Draft
Make apply more memory-friendly for CUDA#407VidithM wants to merge 2 commits intoDrTimothyAldenDavis:dev2from
VidithM wants to merge 2 commits intoDrTimothyAldenDavis:dev2from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(would it be better to instead change the API for GB_apply_op to have a
do_iso_expansionflag? The drawback with the current solution is that the expansion may be performed when not needed, if C is not iso on input.)