Fix u3d console not working on Ruby 3.3+#449
Open
niezbop wants to merge 2 commits intoDragonBox:masterfrom
Open
Fix u3d console not working on Ruby 3.3+#449niezbop wants to merge 2 commits intoDragonBox:masterfrom
niezbop wants to merge 2 commits intoDragonBox:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
bundle exec rspecto make sure that my PR didn't break any testbundle exec rubocopto make sure that my PR is inline with our code stylePull Request Description
As
u3d consoleis heavily inspired (👀) by fastlane own console command, it suffers from the same issue. With the upgrade to Ruby >= 3.3, IRB is changing the way its workspace is setup and this breaks the console command (see fastlane's issue fastlane/fastlane#29924 for a more detailed description).This PR fixes the console command by properly assigning its workspace and adds a spec file to validate the changes. All credit goes to @lacostej for his own PR on fastlane, which I shamelessly copied here :)
This was validated locally against Ruby 2.6.10 and Ruby 3.3.6.