Repository navigation
Report actions still on a moving tag in the weekly triage - #11
Merged
Merged
Conversation
Pinning every action to a commit was a one-off, done by hand. What notices the next workflow added with `@v4` on it is this: the triage now lists, per repository, every reference that is still a tag or a branch rather than a commit. It sits under Drifting, because that is what it is -- nothing is on fire, and left alone it quietly stops being true. Two mistakes worth recording, because both produced a green answer from a check that could not see anything: `gh api --jq '.[].name'` prints one name per line, which is not JSON, so gh() discarded it and the directory read as empty. Every repository came back fully pinned, including the ones with twenty-five loose references. A workflow file is not JSON either. Reading one through gh() returned None and the loop skipped it. gh_text() exists for that, and says so. A security check that answers "all clear" when it cannot read anything is worse than no check, so the fix for both is the same: read what is actually there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pinning was a one-off done by hand. This is what notices the next workflow added with
@v4on it: the triage lists, per repository, everyuses:still on a tag or a branch. Filed under Drifting — nothing on fire, but left alone it stops being true.Verified against the live organisation:
Two bugs found while building it, both of which made the check answer all clear while seeing nothing:
gh api --jq '.[].name'prints lines, not JSON, sogh()discarded the directory listing; and a workflow file is not JSON either, so reading one throughgh()returned None.gh_text()exists for the second. Both are in the commit message — a security check that reports success when it cannot read is worse than no check.