Minor code quality improvements

[DropSnorz]

No description provided.

[coderabbitai]

Walkthrough

The PR performs a broad refactoring across 20+ files: removing unused imports, eliminating explicit public modifiers from interface methods (which remain implicitly public), removing ApplicationDefaults dependency from PluginPathFragmentController and its callers, converting a DirectoryCheck inner class to a Java record with updated accessors, removing throws Exception clauses from Task call methods, adding early exit logic to PluginFileCollector, and applying minor formatting and documentation fixes.

Changes

Cohort / File(s)	Summary
Interface visibility cleanup AccountItem.java, IDirectory.java, IEntityCreateOrUpdate.java, ProgressCallback.java	Removed explicit public modifiers from interface method declarations; methods remain implicitly public per Java semantics. No behavioral impact.
ApplicationDefaults removal PluginPathFragmentController.java, OptionsController.java, WelcomeDialogController.java	Eliminated ApplicationDefaults parameter from PluginPathFragmentController constructor and all call sites. Constructor now takes 6 parameters instead of 7.
DirectoryCheck record refactoring PluginPathFragmentController.java	Converted DirectoryCheck from static class with getStatus()/getMessage() getters to Java record with status()/message() accessors. Updated all references throughout the file.
Task exception handling ExploreController.java, NewSourceDialogController.java	Removed throws Exception clauses from Task.call() method signatures; exceptions now propagate as runtime exceptions without declaration.
Repository visibility & formatting UserAccountRepository.java, RemotePackageRepository.java, FileStatRepository.java	Reduced visibility of repository query methods from public to package-private; adjusted annotation formatting (spacing around equals signs).
Import cleanup OwlPlug.java, ExploreController.java, ScopedScanEntityCollector.java, PlatformUtils.java	Removed unused imports (PropertyVetoException, Dialog, DialogLayout, ApplicationDefaults, FileUtils, ArrayList, List, blank lines). No logic changes.
Minor logic & formatting FileUtils.java, TaskBarController.java, AppUpdateService.java, InstallStepDialogController.java	Added braces to if-block for clarity, replaced explicit generic type parameters with diamond operator, fixed comment punctuation, corrected documentation typo.
PluginFileCollector optimization PluginFileCollector.java	Added early exit (break) from nested-plugin detection loop when a match is found, short-circuiting further comparisons.
FXML structural changes DonateView.fxml, PluginPathFragment.fxml	Simplified XML structure: converted explicit closing tag to self-closing tag, removed redundant <children> wrapper block in HBox. Functionally equivalent.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~30 minutes

Possibly related PRs

• Plugin directory exists and write checks in options #387: Directly modifies PluginPathFragmentController constructor signature and related FXML file structure, overlapping with this PR's refactoring.
• Incremental plugin scan #359: Changes WelcomeDialogController initialization and PluginPathFragmentController usage patterns, both affected in this PR.
• Add plugin table view #280: Removes ApplicationDefaults dependency from PluginPathFragmentController and propagates changes to caller sites, aligning with the core refactoring here.

🚥 Pre-merge checks | ❌ 3

❌ Failed checks (1 warning, 2 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 13.79% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check	❓ Inconclusive	The title 'Minor code quality improvements' is vague and generic, using non-descriptive language that doesn't clearly convey what specific changes were made.	Consider using a more specific title that highlights the primary change, such as 'Remove redundant public modifiers from interface methods' or 'Refactor DirectoryCheck to use Java record'.
Description check	❓ Inconclusive	No pull request description was provided by the author, making it impossible to evaluate whether it relates to the changeset.	Add a pull request description that explains the purpose and scope of the code quality improvements included in this PR.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[DropSnorz]

@coderabbitai review

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.