Skip to content

Add arm64ec support#435

Merged
DropSnorz merged 1 commit intomasterfrom
feat/arm64ec
Jan 29, 2026
Merged

Add arm64ec support#435
DropSnorz merged 1 commit intomasterfrom
feat/arm64ec

Conversation

@DropSnorz
Copy link
Owner

@DropSnorz DropSnorz commented Jan 28, 2026

Relates to #432

@DropSnorz DropSnorz added this to the 1.32.0 milestone Jan 28, 2026
@coderabbitai
Copy link

coderabbitai bot commented Jan 28, 2026

Walkthrough

Expands platform support across Windows, macOS, and Linux with new architecture variants including ARM64 and ARM64EC. Updates RuntimePlatformResolver to recognize additional platform identifiers and adjust cross-platform compatibility mappings. Adds corresponding platform filter options to ExploreController for UI consistency.

Changes

Cohort / File(s) Summary
Platform architecture expansion
owlplug-client/src/main/java/com/owlplug/core/components/RuntimePlatformResolver.java
Renames winX86 to winX32; adds Windows (win-arm64, win-arm64ec), macOS (mac-arm64), and Linux (linux-x32, linux-x64, linux-arm32, linux-arm64) platform entries. Updates compatibility: win-x64 now includes win-x32; win-arm64ec gains compatibility with win-x64. Extends architecture resolution to differentiate arm64ec from arm64.
Platform filter UI updates
owlplug-client/src/main/java/com/owlplug/explore/controllers/ExploreController.java
Adds "win-arm64" and "win-arm64ec" platform filter options to targetFilterCheckBoxes initialization.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Add arm64ec support' directly and specifically describes the main change in the changeset, which adds arm64ec architecture support across multiple platform definitions and controllers.
Description check ✅ Passed The description 'Relates to #432' is minimally related to the changeset as it references an issue, though it provides very limited detail about the actual changes.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@DropSnorz
Copy link
Owner Author

@coderabbitai review

@coderabbitai
Copy link

coderabbitai bot commented Jan 28, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In
`@owlplug-client/src/main/java/com/owlplug/core/components/RuntimePlatformResolver.java`:
- Around line 61-62: The compatibility list for ARM64EC is missing ARM64, so
update the runtime-platform mapping by adding winArm64 to winArm64ec's
compatible platforms (i.e., call
winArm64ec.getCompatiblePlatforms().add(winArm64)) alongside the existing winX64
entry so ARM64-targeted bundles are shown as compatible with the winArm64ec
platform; locate the winArm64ec variable and its getCompatiblePlatforms setup to
make this change.

@DropSnorz DropSnorz merged commit 0f1b3be into master Jan 29, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant