fix(namecheap): Fix XML namespace and DNSRecord type conversion #76
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
encountered by @jameslbarnes
Two bugs that caused all existing DNS records to be deleted:
XML namespace mismatch: XPath queries used https:// but Namecheap API returns http:// namespace, causing get_dns_records() to always return 0 records.
DNSRecord to dict conversion: create_dns_record() and delete_dns_record() passed DNSRecord objects to _set_dns_records() which expected dicts.
🤖 Generated with Claude Code