Review guide: 9 green PRs ready to merge (quick wins take ~5 min) #21

Overview

There are currently 9 open PRs covering all known issues in this repository. This issue serves as a review guide with a conflict-aware merge order.

🎯 Quick Wins — Start Here

These PRs take under 3 minutes to review and have zero risk:

Suggested Merge Order

Some PRs modify the same files and will conflict if merged in the wrong order. The order below minimizes rebase friction — each PR applies cleanly when the ones above it are already merged.

Phase 1: Infrastructure (no conflicts with anything)

1. ci: modernize CI matrix and add Windows testing #24 — Modernize CI matrix and add Windows testing (1 file, trivial)
2. fix: packaging and code hygiene fixes #25 — Packaging: cpanfile fix, 3-arg open, URL casing (4 files, three one-liners)
3. fix: prevent code injection in digest-bench #16 — Fix code injection in digest-bench (3 files, straightforward)

Phase 2: Bug fixes

4. fix: encode UTF-8 flagged strings to bytes in Digest->add() #11 — Fix broken UTF-8 string handling (issue Broken handling of unicode strings [rt.cpan.org #54369] #2) — modifies Digest.pm new() (5 files, +172/−16)
5. fix: add AUTOLOAD DESTROY guard, document digest_file_ctx #26 — AUTOLOAD DESTROY guard, modernize Digest::file, document digest_file_ctx (5 files, +65/−18)

Phase 3: Test coverage

6. test: add edge case tests for Digest::base and fix b64digest arg forwarding #22 — Fix b64digest arg forwarding + edge case tests — modifies Digest/base.pm (4 files, +234/−13)

Phase 4: Features (depend on earlier PRs)

7. feat: add URL-safe base64 digest method (b64url_digest) #23 — URL-safe base64 (b64url_digest, RFC 4648) — conflicts with test: add edge case tests for Digest::base and fix b64digest arg forwarding #22 and fix: add AUTOLOAD DESTROY guard, document digest_file_ctx #26 if they haven't merged first. Touches base.pm, file.pm, t/base.t, t/file.t. (6 files, +104/−18)
8. fix: Add encoding option to Digest->new() for charset normalization #10 — Encoding option for Digest->new() (issue character-sets [rt.cpan.org #80306] #3) — conflicts with fix: encode UTF-8 flagged strings to bytes in Digest->add() #11 on Digest.pm new(). (5 files, +277/−13)

Phase 5: Docs

9. test: add dispatch tests and CLAUDE.md #19 — Add dispatch tests and CLAUDE.md (5 files, +194/−12)

Review Effort Summary

Conflict Map

PRs that touch the same files (will need rebase if merged out of order):

CI Status (2026-07-23)

All PRs are mergeable (no conflicts with main).

Notes

• All PRs are rebased on current main (v1.20 release).
• PRs fix: Add encoding option to Digest->new() for charset normalization #10 and fix: encode UTF-8 flagged strings to bytes in Digest->add() #11 address open issues character-sets [rt.cpan.org #80306] #3 and Broken handling of unicode strings [rt.cpan.org #54369] #2 respectively.
• Consolidated from 13 PRs to 9 in April 2026.
• Upstream (gisle/digest) dormant since 2014. Fork (Dual-Life/Digest) is the active maintenance point.

Cross-repo cleanup (2026-05-26)

Duplicate PRs on upstream (gisle/digest) have been closed:

• CVE-2016-1238: Digest may load an optional module from the current directory [rt.cpan.org #116512] #5 → fix: prevent code injection in digest-bench #16, uses barewords for file handles. we should fix this. #8 → feat: add URL-safe base64 digest method (b64url_digest) #23, Missing version info for module 'Digest' #9 → test: add edge case tests for Digest::base and fix b64digest arg forwarding #22, fix: Add encoding option to Digest->new() for charset normalization #10 → ci: modernize CI matrix and add Windows testing #24, fix: use 3-arg open in t/base.t #13 → fix: add AUTOLOAD DESTROY guard, document digest_file_ctx #26
• "local $@" error in Digest 0.17 [rt.cpan.org #85473] #4 (guillemj, "Stop using use vars") — addressed in 1.18 + fix: add AUTOLOAD DESTROY guard, document digest_file_ctx #26

🤖 Updated by Kōan — added review effort estimates and quick-win recommendations (2026-07-23)